Skip to content

remove "let _ = #[must_use]" pattern - #465

Open
Natural-selection1 wants to merge 3 commits into
vivoblueos:mainfrom
Natural-selection1:chore/no-more-let-underscore
Open

Natural-selection1 wants to merge 3 commits into
vivoblueos:mainfrom
Natural-selection1:chore/no-more-let-underscore

Conversation

@Natural-selection1

@Natural-selection1 Natural-selection1 commented Aug 27, 2026

Copy link
Copy Markdown
  1. add #[must_use] for all xxxGuard
  2. remove "let _ = #[must_use]" pattern

edit:

move no-let-underscore from external to kernel/infra

@han-jiang277 han-jiang277 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Natural-selection1
Natural-selection1 force-pushed the chore/no-more-let-underscore branch 2 times, most recently from de98abf to 96c14bf Compare August 27, 2026 08:49
@han-jiang277

Copy link
Copy Markdown
Contributor

build_prs

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

❌ Job failed. Failed jobs: check_format (failure), check_license (failure), build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/34447056160.

@Natural-selection1
Natural-selection1 force-pushed the chore/no-more-let-underscore branch from 2f7a359 to f7baa75 Compare September 10, 2026 09:31
@Natural-selection1

Copy link
Copy Markdown
Author

build_prs

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/34461190612.

@Natural-selection1

Copy link
Copy Markdown
Author

build_prs

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/34463540191.

@Natural-selection1

Copy link
Copy Markdown
Author

build_prs

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/35040874611.

@Natural-selection1
Natural-selection1 force-pushed the chore/no-more-let-underscore branch from f7baa75 to dcef9ea Compare September 16, 2026 00:50
@Natural-selection1

Copy link
Copy Markdown
Author

build_prs

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/35041703222.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants