Repository navigation
Fix dotted abbreviation sentence boundaries - #38
Merged
Merged
Conversation
vanderlee
marked this pull request as ready for review
August 18, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
a.m..andA.M..as a sentence boundary.Why
The current parser recognizes
a.as an abbreviation, but punctuation merging leavesm.. How about Greg?in one fragment. Abbreviation merging then joins both sentences. For uppercase initials,M..is also incorrectly classified as an abbreviation because it starts with a capital letter.This makes the existing
testSplitLowercaseInitialAbbreviationsregression fail in every PHP matrix job.Impact
Dotted abbreviations can now end a sentence without swallowing the following sentence. Existing abbreviation and ellipsis behavior remains covered by the test suite.
Validation
src/Sentence.phpa.m..boundaries,e.g.., ordinary ellipses, and existing double-period behavior