Repository navigation
Conversation
Owner
Author
|
Currently explicitely support english hardcoded abreviations. Do not merge as is. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Go. Stop. Wait., the example from issue "Sentences must be at least two words long, unless a linebreak or end-of-text." #4, ordered lists, ellipses, numeric sentence endings, and existing abbreviation behavior.Why
The previous heuristic could not distinguish
Go.from an abbreviation because any short capitalized word ending in a period was treated as one. Ordered-list prefixes still need to remain attached to their item text, and legacy abbreviation and ellipsis behavior must remain stable.Validation
The focused patch workflow passed all 35 tests and 123 assertions on PHP 8.4. The complete stacked GitHub Actions matrix also passed on PHP 5.4, 5.6, 7.4, 8.0, 8.4, and 8.5.
This broader abbreviation classification overlaps the narrower change in PR #33 and should replace that parser portion rather than be merged independently after it.
Closes #4.
Closes #23.