Repository navigation
Avoid mbregex retry failures while trimming - #31
Merged
vanderlee merged 4 commits intoAug 3, 2026
Merged
Conversation
…o agent/fix-issue-27-unicode-trim # Conflicts: # tests/SentenceTest.php
vanderlee
marked this pull request as ready for review
August 3, 2026 19:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
mb_ereg_replace()trim expression with Unicode-aware PCRE trimming.trim()only when PCRE rejects malformed input.Why
Issue #27 reports
mb_ereg_replace()exhausting the mbregex retry limit and returningfalse, which then breaks sentence processing. Trimming only the two string boundaries does not require the stateful mbregex search engine.Dependency
This is a stacked draft based on PR #30 so the regression suite runs on the replacement GitHub Actions matrix. After PR #30 merges, this PR can be retargeted to
master.Closes #27.