[SC-18126] Insert variables in the Create Artifact step's title and description - #1497
Merged
juanmleng merged 3 commits intoSep 7, 2026
Merged
Conversation
The Create Artifact step's Title and Description now accept the same variables the Broadcast step's Subject and Message accept, so an artifact raised by a workflow can name the record it runs against — and, on a breach-triggered workflow, the metric that breached. - Workflow step types: a footnote on Title covering both fields, following the pattern the Broadcast rows use. It notes that variables which cannot be filled in for this step are not offered, and that Title is stored as plain text while Description keeps its formatting. - Trigger workflows on threshold breach: the breach-details section covered broadcasts only, so it is widened to both steps and retitled. The trigger-change warning now says the rejection names the step as well as the variable, and the "what a breach sends" note records that one artifact is raised per breach rather than per failing reading. The retitled section changes its anchor, so the Broadcast footnote's link to it is repointed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The Monitoring Breach table was retitled from "broadcast variables" to "variables" and moved under a section covering both the Broadcast and Create Artifact steps, but it still lists Monitoring Document URL without qualification. That variable is withheld from Create Artifact, along with Record URL, so a reader following this page opens the picker and cannot find the row the table promised. Mark the row, and say why once: a link is written differently for each reader, so it suits a step that writes its text once per recipient and not one that writes once and stores the result for everyone. The step types footnote gave two reasons for a variable being absent -- no recipient, and no artifact yet -- and neither covers a link, so it gains the same sentence. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011uw61mH5X2xvAG6XQobTVh
Contributor
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
panchicore
approved these changes
Sep 7, 2026
panchicore
left a comment
Member
There was a problem hiding this comment.
Verdict: Approve
Every factual claim in the diff checks out against validmind/backend@bef66e60 and validmind/frontend@a9482fc0 (both on main).
Verified
- Variable set/scoping:
PER_RECIPIENT_VARIABLES(backend/src/backend/notifications/broadcast_variables.py) withholdsUser.full_name,Model.url,Monitoring.document_url,Artifact.url.get_broadcast_variable_registry(..., rendered_per_recipient=False)filters these out;managers.py::on_create_artifactcalls it withrendered_per_recipient=False, and the/variablesroute setsrendered_per_recipient=node_type != NODE_ARTIFACT_CREATE. FrontendArtifactCreatePanelpassesnode_type: 'artifact_create'. Doc's "variables that cannot be filled in for this step are not offered" and "Monitoring Document URL ... available to Broadcast only" both hold. - "Record URL under Record Details":
_make_category("broadcast-record", "Record Details", details_variables)includesModel.url→"Record URL"(fromLEGACY_BROADCAST_VARIABLES). Not a doc anchor — it's the in-product picker category name, matching the file's existing convention of bolding UI group/step names. - Title plain-text / Description formatting:
managers.py::on_create_artifactiterates("title", True), ("description", False)for theflattenarg to_clean_artifact_variable_text; frontend serializes Title througheditorHtmlToMinimal(strips all but variable spans) and Description through the full CKEditor HTML. Matches doc exactly. - Monitoring breach variable names:
MONITORING_VARIABLES= Breached Metric Key/Name/Value/Thresholds, Monitoring Document URL — exact match to the doc's table. - chatbot-product-map.md: all 4 stale
Include breach details in notificationssection-list entries updated to the new heading; grepped the wholesite/tree, no remaining stale references to the old text or old anchor. - Quarto hygiene: rendered both changed pages locally (quarto 1.9.38).
#create-artifactspan and new#include-breach-details-in-an-artifact-or-a-notificationsection id both resolve; the[^broadcast]/[^artifact-text]footnote pair follows the existing pattern exactly; footnote numbers 1–7 in the threshold-breach page are unique, no collision. Only warnings were pre-existing/unrelated (validmind/validmind.qmdlink, not touched by this PR). - Style: voice and product terminology (record/artifact, "Inventory Record" not used loosely) consistent with surrounding text and frontend AGENTS.md.
Fix later / nits
None — the PR body already flags the one behavior-relevant risk itself (anchor rename, single in-repo reference, already repointed) and it's handled correctly.
Accepted risks
- PR body notes this describes behavior that hadn't merged at PR-open time; both backend#3561 and frontend#2862 are now merged to main, so that's resolved.
Verification
gh pr view 1497 -R validmind/documentation --json headRefOid→c39adb769fca138fb5f39e2a9c6fe3f7ff10618a(matches reviewed worktree).- Read backend
broadcast_variables.py,workflows/managers.py(on_create_artifact),routes/internal/broadcast.py,handlers/broadcast_handlers.pyatorigin/main. - Read frontend
ArtifactCreatePanel/index.tsxatorigin/main. quarto renderboth changed.qmdpages to HTML and inspected output for anchors/footnotes.grep -rnfor stale anchor/section text acrosssite/.
juanmleng
deleted the
juan/sc-18126/insert-variables-in-create-artifact-step
branch
September 7, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What and why?
The Create Artifact workflow step's Title and Description now accept the same variables the Broadcast step's Subject and Message accept, so an artifact raised by a workflow can name the record it runs against, its stakeholders or its fields — and, on a workflow triggered by a monitoring threshold breach, the metric that breached, its value and thresholds.
Two pages needed it:
How to test
Live preview
Both changed pages, on the branch's own preview build — no local render needed:
The preview redeploys on every push, so these always show the branch as it currently stands. Give the Validate docs site check a moment to finish after a new commit.
Render locally
Both changed pages render:
Then check, in the rendered output:
workflow-step-types.html#broadcastand#create-artifact.Verified locally on both pages.
What needs special review?
The retitled section changes its anchor. "Include breach details in notifications" is now "Include breach details in an artifact or a notification", so
#include-breach-details-in-notificationsno longer exists. The one in-repo reference — the Broadcast footnote in Workflow step types — is repointed in this PR, and I confirmed there are no others in the source. Any link to the old anchor from outside this repo would break.The wording describes behaviour that has not merged yet. These pages will describe the feature before the code shipping it is released; see the dependencies below.
Dependencies, breaking changes, and deployment notes
Release notes
The documentation for the Create Artifact workflow step now covers building its Title and Description from variables, and the monitoring threshold breach guide covers using the breached metric's details in an artifact as well as in a broadcast.
Checklist
SC-18126