Skip to content

fix: allow offline OCP version override - #148

Merged
butler54 merged 3 commits into
validatedpatterns:mainfrom
butler54:fix/ocp-version-env-override
Sep 7, 2026
Merged

fix: allow offline OCP version override#148
butler54 merged 3 commits into
validatedpatterns:mainfrom
butler54:fix/ocp-version-env-override

Conversation

@butler54

@butler54 butler54 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • support OCP_VERSION when bare-metal reference values are collected without an authenticated cluster
  • standardize Python entry points on Typer for CLI parsing and Rich for console output
  • centralize Python dependencies in root requirements.txt; RHDP wrappers install it with their selected Python 3.10+ interpreter
  • document the connected staging-host workflow, root dependency installation, and airgap Git server prerequisites
  • add pytest CLI smoke tests

Validation

  • pytest -q
  • python3 -m py_compile scripts/collect_firmware_refvals.py scripts/git-http-server.py rhdp/rhdp-cluster-define.py
  • targeted OCP_VERSION and --ocp-version precedence checks
  • bash -n rhdp/wrapper.sh rhdp/wrapper-multicluster.sh rhdp/wrapper-cluster-only.sh
  • python3 -m pip install --dry-run -r requirements.txt
  • python3 -m pip check
  • git diff --check

Closes #147

@butler54
butler54 requested a review from a team September 7, 2026 01:27
@butler54
butler54 merged commit f69140f into validatedpatterns:main Sep 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: make collect-firmware-refvals has no mechanism to override OCP VERSION

1 participant