Skip to content

Use project root from path config - #2854

Merged
DavyLandman merged 2 commits into
mainfrom
fix/use-projectroot-from-pathconfig
Sep 8, 2026
Merged

Use project root from path config#2854
DavyLandman merged 2 commits into
mainfrom
fix/use-projectroot-from-pathconfig

Conversation

@toinehartman

@toinehartman toinehartman commented Aug 18, 2026

Copy link
Copy Markdown
Member

Use the project root from the path config instead of using a separate argument.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 45%. Comparing base (8da8d0f) to head (0b139a9).

Files with missing lines Patch % Lines
src/org/rascalmpl/shell/RascalTest.java 0% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2854   +/-   ##
=======================================
- Coverage       45%     45%   -1%     
+ Complexity    6797    6788    -9     
=======================================
  Files          843     843           
  Lines        68798   68798           
  Branches     10030   10029    -1     
=======================================
- Hits         31361   31335   -26     
- Misses       35056   35080   +24     
- Partials      2381    2383    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jurgenvinju jurgenvinju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@toinehartman
toinehartman force-pushed the fix/use-projectroot-from-pathconfig branch from 7dd66a9 to 0c0ccdf Compare August 18, 2026 11:30
@toinehartman
toinehartman force-pushed the fix/extract-classpath-computation branch from f59ef86 to a57cc67 Compare August 18, 2026 11:30
@toinehartman
toinehartman marked this pull request as ready for review August 18, 2026 12:28
@toinehartman
toinehartman marked this pull request as draft August 18, 2026 12:30
@DavyLandman
DavyLandman force-pushed the fix/extract-classpath-computation branch from a57cc67 to 40364f8 Compare August 18, 2026 13:15
@DavyLandman
DavyLandman force-pushed the fix/use-projectroot-from-pathconfig branch from 0c0ccdf to a10ca7f Compare August 18, 2026 13:15
Base automatically changed from fix/extract-classpath-computation to main August 18, 2026 13:37
@DavyLandman
DavyLandman force-pushed the fix/use-projectroot-from-pathconfig branch from a10ca7f to c9c0342 Compare August 18, 2026 13:37
@toinehartman
toinehartman marked this pull request as ready for review September 8, 2026 10:58
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@DavyLandman
DavyLandman merged commit 2acd8f2 into main Sep 8, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants