syntax role modifiers

[jurgenvinju]

This PR implements syntax role modifiers.

SyntaxModifiers.pdf

• runtime types for modifiers with open and closed parameters, including subtype, lub and glb
• subtype lub and glb for Symbol and AType
• conversions for AST,Symbol and AType
• JGenie code generator for open type modifiers
• tests for using modifiers
• Correct implementation of Explode: AST to separator syntax Tree conversion, using role modifiers
• Tests for Explode
• Fixes for deep match on separator syntax trees
• Tests for deep match
• Fixes for visit on separator syntax trees (not required since no bugs found)
• Tests for visit
• Fixes for match on separators syntax trees (impossible to discover see below)
• Tests for match (impossible to write on this PR because external parsers are not called on concrete syntax yet)

[codecov]

Codecov Report

❌ Patch coverage is 9.27673% with 577 lines in your changes missing coverage. Please review.
✅ Project coverage is 45%. Comparing base (4f96714) to head (fc82a86).
⚠️ Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
src/org/rascalmpl/types/ModifySyntaxRole.java	0%	309 Missing ⚠️
src/org/rascalmpl/ast/SyntaxRoleModifier.java	0%	114 Missing ⚠️
...ascalmpl/semantics/dynamic/SyntaxRoleModifier.java	0%	27 Missing ⚠️
src/org/rascalmpl/ast/Type.java	21%	25 Missing ⚠️
src/org/rascalmpl/library/Type.java	33%	24 Missing ⚠️
src/org/rascalmpl/types/RascalTypeFactory.java	4%	21 Missing and 1 partial ⚠️
...org/rascalmpl/values/parsetrees/SymbolFactory.java	5%	16 Missing ⚠️
src/org/rascalmpl/ast/NullASTVisitor.java	0%	6 Missing ⚠️
...almpl/interpreter/staticErrors/UnexpectedType.java	25%	4 Missing and 2 partials ⚠️
src/org/rascalmpl/types/RascalType.java	0%	6 Missing ⚠️
... and 9 more

Additional details and impacted files

@@           Coverage Diff            @@
##              main   #1835    +/-   ##
========================================
- Coverage       45%     45%    -1%     
- Complexity    6801    6819    +18     
========================================
  Files          844     848     +4     
  Lines        68785   69424   +639     
  Branches     10023   10136   +113     
========================================
+ Hits         31344   31469   +125     
- Misses       35066   35575   +509     
- Partials      2375    2380     +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jurgenvinju]

This PR is almost done. Needs some cleaning of unrelated changes and attention to new TODO comments.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jurgenvinju]

@rodinaarssen could you have a look at this? especially if you think we need more tests.