fix(core): add null frame guards to RwFrameRotate and gauge indicators - #337
Open
CanerKaraca23 wants to merge 1 commit into
Open
CanerKaraca23 wants to merge 1 commit into
CanerKaraca23 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds defensive null pointer checks across core frame rotation utilities and vehicle gauge indicators to prevent access violation crashes during vehicle frame manipulation.
Problem
When third-party plugins (such as VehFuncs or VehIK) detach or hide optional vehicle model frames, or when models stream in with missing odometer drum frames, passing
nullptrtoRwFrameRotatedereferencesframe->modellingat offset+0x1C, causing an access violation crash0xC0000005 at 0x007F1F1F.Changes
src/utils/frame.cpp: Addedif (!frame) return;guard toFrameUtil::SetRotationX,SetRotationY, andSetRotationZ.src/features/core/dummy.h: Added&& data.frameguard inVehicleDummy::AddAngleandVehicleDummy::ReduceAngle.src/features/gauge.cpp: Added null frame pointer check (indicator.vecFrameList[i]) before rotating odometer drum frames inMileageIndicator::Init.