Skip to content

feat: Epic A — Alarms that act (inbox + ignore) - #35

Open
ultimaterex wants to merge 10 commits into
masterfrom
feat/alarms-act
Open

feat: Epic A — Alarms that act (inbox + ignore)#35
ultimaterex wants to merge 10 commits into
masterfrom
feat/alarms-act

Conversation

@ultimaterex

Copy link
Copy Markdown
Owner

Summary

  • Full-enough Firewalla alarms inbox: prefer live get alarms when control is paired + lan-ok, else keep dual-source agent/init bootstrap with provenance (fw-app-get / agent / fw-app-init).
  • Writes: POST /v1/fw-app/alarms/ignore and ignore-all (alarm:ignore / alarm:ignoreAll), Control History audit, UI Alarms tab + Metrics StatCard drill-in + notifications bell hub (alarms + Audit).
  • Hermetic Go tests; no metrics-tick :8833 poll; Redis _alarm:* / create-rule-from-alarm / exceptionRules out of scope.
  • Fix: gofmt alignment in controlhist/types.go (CI failure on prior PR).

Type of change

  • New feature

✅ Required (must be checked to merge)

Checklist

  • My changes build: go vet/gofmt clean path exercised via tests; npm run build for UI.
  • Tests pass: go test fireproxy/pkg/... fireproxy/agent/... fireproxy/server/....
  • Hermetic tests for behavior changes (SetSendFn / facade stubs; no real host/network).
  • No secrets or real network data committed.
  • Docs: local design/plan under local/superpowers/ (gitignored); README API blurb optional follow-up.
  • Focused Epic A scope.

Test plan

  • Hermetic: go test fireproxy/server/internal/fwapp fireproxy/server/internal/observatory fireproxy/server/internal/api -count=1
  • UI: open Alarms tab, Metrics Alarms card, bell hub sections; ignore one (no confirm); ignore-all modal with count
  • Lab gate (2026-08-15-fw-app-lab-gate.md): paired + LAN OK, dismiss one alarm on real box, confirm Control History row

Notes for reviewers

  • Spec/plan: local/superpowers/specs/2026-08-26-alarms-act-design.md, local/superpowers/plans/2026-08-26-alarms-act.md
  • Live ignore still needs lab gate proof on a real box before calling Epic A “done” operationally.
  • Supersedes feat: Epic A — Alarms that act (inbox + ignore) #34 (closed to retrigger CI after gofmt).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant