feat: Epic A — Alarms that act (inbox + ignore) - #35
Open
ultimaterex wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get alarmswhen control is paired +lan-ok, else keep dual-source agent/init bootstrap with provenance (fw-app-get/agent/fw-app-init).POST /v1/fw-app/alarms/ignoreandignore-all(alarm:ignore/alarm:ignoreAll), Control History audit, UI Alarms tab + Metrics StatCard drill-in + notifications bell hub (alarms + Audit).:8833poll; Redis_alarm:*/ create-rule-from-alarm / exceptionRules out of scope.controlhist/types.go(CI failure on prior PR).Type of change
✅ Required (must be checked to merge)
Checklist
go vet/gofmtclean path exercised via tests;npm run buildfor UI.go test fireproxy/pkg/... fireproxy/agent/... fireproxy/server/....local/superpowers/(gitignored); README API blurb optional follow-up.Test plan
go test fireproxy/server/internal/fwapp fireproxy/server/internal/observatory fireproxy/server/internal/api -count=12026-08-15-fw-app-lab-gate.md): paired + LAN OK, dismiss one alarm on real box, confirm Control History rowNotes for reviewers
local/superpowers/specs/2026-08-26-alarms-act-design.md,local/superpowers/plans/2026-08-26-alarms-act.md