Repository navigation
Release v1.18.0: white operating states and emitter channels - #71
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@greptileai review |
Codex Automated Code ReviewCode Review SummaryPR: ULC 1.18.0 adds published color states, emitter channels, endpoint grading, workbook conversion, and a tunable-white example. Reviewed all 58 changed files. P0 - Critical Issues (Must Fix)None found. P1 - High Priority Issues (Should Fix)None found. P2 - Medium Priority Issues (Consider Fixing)None found. P3 - Low Priority Issues (Optional)None found. Positive Observations
Validation: both schemas pass Draft 2020-12 structural checks, all 310 Automated review by OpenAI Codex |
|
REBUTTED (no change required): the Codex automated review reports no actionable P0, P1, P2 or P3 findings on REBUTTED (no change required): the Codex connector summary also completed on |
[High impact] The PR appears safe to merge, with no new actionable issues found.
|
|
FIXED (G1) / REBUTTED (G2): the Greptile review at REBUTTED (no change required): Greptile subsequently reviewed REBUTTED (no change required): Greptile also reviewed final head |
Codex Automated Code ReviewCode Review SummaryPR: ULC 1.18.0: published color states, emitter channels, endpoint grading, workbook conversion, and a tunable-white example. P0 - Critical Issues (Must Fix)None found. P1 - High Priority Issues (Should Fix)
P2 - Medium Priority Issues (Consider Fixing)None found. P3 - Low Priority Issues (Optional)None found. Positive Observations
Validation limitation: The Go test suite could not start because the read-only environment prevents creation of Go’s build cache. Automated review by OpenAI Codex |
|
REBUTTED (scope): in 1.18.0, published color states are white operating states with a CCT by design. The shared identity rule uses CCT, dim level and label, and the two endpoint grading rows read those white states. Colored emitters are represented as emission channels with peak wavelength, flux and spectrum; a colored scene such as an RGB Red preset is a different concept and is outside this release. The schema and workbook refusal demonstrated here match that intended scope. This answers the automatic Codex review of af4b327. The full local gate passed for the clarification commit. |
Codex Automated Code ReviewCode Review SummaryPR: ULC 1.18.0 adds published white operating states, emitter channels, endpoint grading, generated CCT ranges, workbook conversion, and a reference example. P0 - Critical Issues (Must Fix)None found. P1 - High Priority Issues (Should Fix)None found. P2 - Medium Priority Issues (Consider Fixing)None found. P3 - Low Priority Issues (Optional)None found. Positive Observations
Validation completed: both schemas pass Draft 2020-12 metaschema checks, all 310 The Go test suite could not run because the read-only environment prevents creation of Go’s build cache. Runtime behavior and index parity remain unverified here. Automated review by OpenAI Codex |
|
REBUTTED (no change required): the automatic Codex review of final head f66bbc1 reports no actionable P0, P1, P2 or P3 findings. Its schema checks passed. Runtime tests were unavailable in the reviewer's read-only cache environment; the separate same-head Validator CI executed successfully, and the local mandatory gate passed, including race tests and all nine validation/index checks. Release notes and schema-reference CI also passed on REBUTTED (no change required): the Codex connector summary also completed on this final head with has_any_findings=false and has_unresolved_findings=false. All emitted Codex review results on the pushed heads have been answered, including the af4b327 scope request. |
Summary
Records can now publish white operating states for tunable-white, dim-to-warm and multichannel luminaires, plus emitter channels, alongside the tested baseline. A referenced
color_tuningblock, one shared resolver and consistency validation keep the baseline authoritative, while builder 0.11.0 projects both numeric range endpoints. The workbook adds color-state and emitter-channel sheets with independent spectrum groups. Shared PIM guidance maps the new authored fields and generated range fields, with links from all four platform guides.This prepares ULC 1.18.0 and adds one public LCVA example with endpoint report values and the original measured spectra. The eight existing examples retain their grades and change only the builder marker.
Test plan
go vet ./..., gofmt check,go test -race ./..., and CLI build.build-index --check; schema drift guard resolves all 310 references.Callouts for reviewers
Tunable-white and dim-to-warm records need both endpoint CCTs for Standard and endpoint CRI Ra plus melanopic DER for Full. Stored records without ends fall below Standard after rebuilding. Existing grading rows continue to read the tested baseline.
Channels and endpoint spectra remain enrichment. The LCVA example is schema-valid at the incomplete floor with its ordinary missing-data roadmap. Unpublished endpoint flux and melanopic DER stay absent; through-optics status is unstated. Source files are individually hashed and excluded from the repository.
scope_versionremains 2.0.0: 71 gating rows, 73 enrichment rows, two observations and 61 gating pointer rows. This release adds schema fields and vocabulary while preserving all eight original example grades.Endpoint-metric roadmap messages retain the uniform row-level
/color_tuning/statescontract. A missing endpoint metric can belong to the top-level tested baseline. The shared mapping guidance explains both homes; endpoint-specific actual-path messages remain a future design refinement.Published states in this release carry CCT and describe white operating conditions. Colored emitters have channel identity, peak wavelength, flux and spectra; colored scene presets are outside 1.18.0.