Skip to content

Add a workbook sheet for the TM-30 hue-bin fidelity values - #70

Merged
foadshafighi merged 5 commits into
mainfrom
release/v1.17.0
Oct 15, 2026
Merged

foadshafighi merged 5 commits into
mainfrom
release/v1.17.0

Conversation

@foadshafighi

Copy link
Copy Markdown
Contributor

Summary

Adds the tm_30_hue_bins workbook sheet for sixteen TM-30 local color fidelity values. The converter requires bins 1 through 16 exactly once and a tm_30_rf headline, resolves provenance per row, and emits entries in ascending bin order at colorimetry.tm_30.rf_h_per_bin.

Includes the template, CSV/XLSX tests, authoring documentation, one schema description correction, and release 1.17.0 version references. Schema structure, taxonomy, grading rules, achievements and index projection remain unchanged; BuilderVersion remains 0.10.0.

Measurement SHA: 7d6491dc11192dfe058ac6d50580c47d0a2d7334.

Gates run

Each of the five implementation commits passed the row gate: go vet ./..., a clean gofmt check, go test -race ./..., CLI build, validation and index parity for all eight examples, and python3 tools/schema-drift-guard.py (297 references across two schema files). sh tools/validator/check-spec-version.sh 1.17.0 passed.

The synthetic fixture converts successfully, and verbose validation has no hue-bin Full gap. CLI probes refuse bin 17, a repeated bin, rf_h=oops, and measured hue bins without an LM-79 anchor with the specified diagnostics. CSV/XLSX tests also cover all thirteen refusal cases and rated provenance.

All eight published examples remain byte-identical with the same measured grades as v1.16.0. A measured workbook without the new sheet produces the same record as the baseline converter after excluding only ulc_version.

Synthetic fixture entries

All sixteen entries have value_type=measured, provenance source=test_report, method=transcribed, attestation_ref=lm79_lumos_skyline_sr_ho, and no unit.

bin rf_h.value
1 71.5
2 72.5
3 73.5
4 74.5
5 75.5
6 76.5
7 77.5
8 78.5
9 79.5
10 80.5
11 81.5
12 82.5
13 83.5
14 84.5
15 85.5
16 86.5

@foadshafighi
foadshafighi requested a review from a team as a code owner October 15, 2026 02:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T02:30:52.369470Z 7d6491d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Codex Automated Code Review

Code Review Summary

PR: Release 1.17.0 adds TM-30 hue-bin workbook conversion, provenance support, tests, and documentation. Reviewed all 23 changed files.

P0 - Critical Issues (Must Fix)

None found.

P1 - High Priority Issues (Should Fix)

None found.

P2 - Medium Priority Issues (Consider Fixing)

None found.

P3 - Low Priority Issues (Optional)

None found.

Positive Observations

  • Hue-bin conversion enforces sixteen unique bins and produces deterministic bin ordering.
  • Reuses existing provenance checks for measured and derived values, including evidence-family and manufacturer-confirmation restrictions.
  • Tests cover CSV/XLSX parity, malformed values, missing bins, provenance failures, and completeness integration.
  • Documentation and release-version updates are consistent across changed files.

Validation: Schema drift guard passed: all 297 references resolve. Go tests could not run because the read-only environment prevents creation of Go’s build cache.


Automated review by OpenAI Codex

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Adds the optional tm_30_hue_bins workbook sheet and stamps newly converted records with version 1.17.0.

  • Workbooks can now supply all sixteen TM-30 hue-bin fidelity values.

No actionable issues were found. Tests were inspected, not executed.

Reviews (1) · Last reviewed commit: "Prepare specification and authoring refe..." · Reviewed by Greptile

@foadshafighi

Copy link
Copy Markdown
Contributor Author

REBUTTED (no change required): both final-head Codex summaries report no P0, P1, P2 or P3 findings at 7d6491dc11192dfe058ac6d50580c47d0a2d7334.

@foadshafighi

Copy link
Copy Markdown
Contributor Author

REBUTTED (no change required): the Greptile review reports no actionable issues and confidence 5/5 on 7d6491dc11192dfe058ac6d50580c47d0a2d7334. There are no inline findings to fix. Greptile inspected the tests; the same-head Validator CI executed them successfully.

@foadshafighi
foadshafighi merged commit 728d7e8 into main Oct 15, 2026
4 checks passed
@foadshafighi
foadshafighi deleted the release/v1.17.0 branch October 15, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant