Repository navigation
Add a workbook sheet for the TM-30 hue-bin fidelity values - #70
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codex Automated Code ReviewCode Review SummaryPR: Release 1.17.0 adds TM-30 hue-bin workbook conversion, provenance support, tests, and documentation. Reviewed all 23 changed files. P0 - Critical Issues (Must Fix)None found. P1 - High Priority Issues (Should Fix)None found. P2 - Medium Priority Issues (Consider Fixing)None found. P3 - Low Priority Issues (Optional)None found. Positive Observations
Validation: Schema drift guard passed: all 297 references resolve. Go tests could not run because the read-only environment prevents creation of Go’s build cache. Automated review by OpenAI Codex |
[Medium impact] The PR appears safe to merge; no actionable issues were found.
|
|
REBUTTED (no change required): both final-head Codex summaries report no P0, P1, P2 or P3 findings at
|
|
REBUTTED (no change required): the Greptile review reports no actionable issues and confidence 5/5 on |
Summary
Adds the
tm_30_hue_binsworkbook sheet for sixteen TM-30 local color fidelity values. The converter requires bins 1 through 16 exactly once and atm_30_rfheadline, resolves provenance per row, and emits entries in ascending bin order atcolorimetry.tm_30.rf_h_per_bin.Includes the template, CSV/XLSX tests, authoring documentation, one schema description correction, and release 1.17.0 version references. Schema structure, taxonomy, grading rules, achievements and index projection remain unchanged; BuilderVersion remains 0.10.0.
Measurement SHA:
7d6491dc11192dfe058ac6d50580c47d0a2d7334.Gates run
Each of the five implementation commits passed the row gate:
go vet ./..., a cleangofmtcheck,go test -race ./..., CLI build, validation and index parity for all eight examples, andpython3 tools/schema-drift-guard.py(297 references across two schema files).sh tools/validator/check-spec-version.sh 1.17.0passed.The synthetic fixture converts successfully, and verbose validation has no hue-bin Full gap. CLI probes refuse bin 17, a repeated bin,
rf_h=oops, and measured hue bins without an LM-79 anchor with the specified diagnostics. CSV/XLSX tests also cover all thirteen refusal cases and rated provenance.All eight published examples remain byte-identical with the same measured grades as v1.16.0. A measured workbook without the new sheet produces the same record as the baseline converter after excluding only
ulc_version.Synthetic fixture entries
All sixteen entries have
value_type=measured, provenancesource=test_report,method=transcribed,attestation_ref=lm79_lumos_skyline_sr_ho, and no unit.