Skip to content

style: trim the uninstall URL comments #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ujiro99 merged 1 commit into from
Sep 22, 2026
Merged

style: trim the uninstall URL comments #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/extension/src/background_script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,8 +498,7 @@ chrome.runtime.onInstalled.addListener(async (details) => {
details.reason === chrome.runtime.OnInstalledReason.UPDATE
) {
// Set uninstall survey URL with client_id for analysis. The version
// rides along so the Hub can put `app_version` on the GA4 `uninstall`
// event it sends on our behalf - by then this service worker is gone
// rides along for the `uninstall` event the Hub sends on our behalf
// (selection-command-hub#275).
// Wrapped in its own try/catch so a failure here (e.g. storage quota
// error) does not skip the backup checks below.
Expand Down
6 changes: 2 additions & 4 deletions packages/extension/src/services/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,8 @@ export const ANALYTICS_EVENTS = {
ONBOARDING_COMMAND_EXECUTE: "onboarding_command_execute",
ONBOARDING_VALUE_REACHED: "onboarding_value_reached",
ONBOARDING_COMPLETE: "onboarding_complete",
// No "uninstall" entry: the service worker is already torn down when the
// extension is removed, so that event is sent by the Hub instead, from the
// uninstall URL set in background_script.ts, using the client_id and
// version carried on it (selection-command-hub#275).
// No "uninstall": the service worker is gone by then, so the Hub sends it
// from the uninstall URL instead (selection-command-hub#275).
} as const

export type AnalyticsEventName =
Expand Down
Loading