MergeInjector breaks normal Angular DI priority #977

Activity

1. msgoloborodov commented on Jan 19, 2023

   

   msgoloborodov

   on Jan 19, 2023

   Last edited by msgoloborodov

   ContributorAuthor

   More actions

   https://angular.io/guide/hierarchical-dependency-injection#resolution-rules
   Angular tries to find dependency in ElementInjector tree, if Angular doesn't find the provider in any ElementInjector hierarchies, it goes back to the element where the request originated and looks in the ModuleInjector hierarchy.
   But UIView creates component with custom injector MergeInjector which firstly search token in ModuleInjector and then in ElementInjector.
   For example, it will return service provided in root ModuleInjector, but it must return service provided in parent component or in lazy module (child module).
   I think it should first look in all parents element injectors and only then in moduleInjector.
2. msgoloborodov commented on Jan 23, 2023

   

   msgoloborodov

   on Jan 23, 2023

   ContributorAuthor

   More actions

   PR to fix this issue: #978.

   👍React with 👍1Reacted by Valentin Moser
3. wawyed commented on Aug 4, 2023

   

   wawyed

   on Aug 4, 2023

   Member

   More actions

   When is this an issue?
4. xfh commented on Dec 31, 2024

   

   xfh

   on Dec 31, 2024

   More actions

   When is this an issue?

   I haven't tested the PR yet, but I know at case where MergeInjector causes a problem. In an angular 18 app (dev-mode), lazy-loaded states are not compatible with angular devtools (chrome extension). They crash with the following error:

   ASSERTION ERROR: getInjectorParent only support injectors of type R3Injector, NodeInjector, NullInjector
       at throwError (core.mjs:525:9)
       at getInjectorParent (core.mjs:30898:5)
       at getInjectorResolutionPathHelper
   

   As a result, the angular devtools don't load. The app is working fine though. The states are loading as they should.