Skip to content

copy an explicitly defined run_size into the generated manifest - #376

Merged
konstantinoscs merged 2 commits into
developfrom
konstantinos/eco-1203-preserve-towerfile-run_size-in-cli-package-manifests
Oct 5, 2026
Merged

konstantinoscs merged 2 commits into
developfrom
konstantinos/eco-1203-preserve-towerfile-run_size-in-cli-package-manifests

Conversation

@konstantinoscs

Copy link
Copy Markdown
Contributor

A Towerfile declaring run_size = "basic.large" loses that setting when the Tower CLI builds MANIFEST. Tower reads the size from the manifest when creating the app version, so retaining it only in the archived Towerfile is insufficient. The requested compute size is silently lost at the packaging boundary.

Verified on October 5, 2026: pending Tower CLI release #375, head 8d175f2, still omits the field. Its packaging test explicitly asserts that omission based on the incorrect assumption that the backend reads the Towerfile.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: tower/tower-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 7f0047a9-ac8b-4a86-990f-533eaefb1a3c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@konstantinoscs
konstantinoscs merged commit 1e36265 into develop Oct 5, 2026
32 checks passed
@konstantinoscs
konstantinoscs deleted the konstantinos/eco-1203-preserve-towerfile-run_size-in-cli-package-manifests branch October 5, 2026 11:15
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants