Skip to content

⚡ Bolt: [performance improvement] O(1) space complexity in discover - #136

Draft
toreleon wants to merge 2 commits into
masterfrom
bolt-perf-discover-allocations-5661365790485880864
Draft

⚡ Bolt: [performance improvement] O(1) space complexity in discover#136
toreleon wants to merge 2 commits into
masterfrom
bolt-perf-discover-allocations-5661365790485880864

Conversation

@toreleon

@toreleon toreleon commented Sep 2, 2026

Copy link
Copy Markdown
Owner

💡 What:
Replaced chained array methods (.map(), .slice(), .reduce()) in src/tools/discover.ts (buildCandidate and rsi14) with standard for loops.

🎯 Why:
During the discovery phase, the tool scans hundreds of tickers, creating multiple temporary arrays for every single candidate when using .map to extract closes and vols, and allocating more arrays with .slice. This creates a massive amount of intermediate objects, leading to high garbage collection overhead and slower execution times.

📊 Impact:

  • Eliminates multiple O(N) temporary array allocations per ticker scanned.
  • Achieves O(1) space complexity for array operations in the hot path.
  • Reduces GC pauses during large universe scans.

🔬 Measurement:
Run pnpm test and verify that discovery logic works identically but with fewer memory allocations.


PR created automatically by Jules for task 5661365790485880864 started by @toreleon

Replaced `.map()` and `.slice().reduce()` chains in `buildCandidate` and `rsi14` with standard `for` loops bounded dynamically, operating directly on the original object array to achieve O(1) space complexity during high-volume ticker scanning.

Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Updated the `pnpm.overrides` field in `package.json` to force `undici` to `>=7.29.0 <8.0.0` resolving the cross-user information disclosure vulnerability reported by `pnpm audit` while maintaining Node 20 compatibility for Vitest.

Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant