⚡ Bolt: [performance improvement] O(1) space complexity in discover - #136
⚡ Bolt: [performance improvement] O(1) space complexity in discover#136toreleon wants to merge 2 commits into
Conversation
Replaced `.map()` and `.slice().reduce()` chains in `buildCandidate` and `rsi14` with standard `for` loops bounded dynamically, operating directly on the original object array to achieve O(1) space complexity during high-volume ticker scanning. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Updated the `pnpm.overrides` field in `package.json` to force `undici` to `>=7.29.0 <8.0.0` resolving the cross-user information disclosure vulnerability reported by `pnpm audit` while maintaining Node 20 compatibility for Vitest. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
💡 What:
Replaced chained array methods (
.map(),.slice(),.reduce()) insrc/tools/discover.ts(buildCandidateandrsi14) with standardforloops.🎯 Why:
During the discovery phase, the tool scans hundreds of tickers, creating multiple temporary arrays for every single candidate when using
.mapto extractclosesandvols, and allocating more arrays with.slice. This creates a massive amount of intermediate objects, leading to high garbage collection overhead and slower execution times.📊 Impact:
🔬 Measurement:
Run
pnpm testand verify that discovery logic works identically but with fewer memory allocations.PR created automatically by Jules for task 5661365790485880864 started by @toreleon