Skip to content

[release-v1.44] node: drop the securityfs hostPath from calico-node - #5325

Open
tomastigera wants to merge 1 commit into
release-v1.44from
tomas/securityfs-self-mount
Open

tomastigera wants to merge 1 commit into
release-v1.44from
tomas/securityfs-self-mount

Conversation

@tomastigera

@tomastigera tomastigera commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bug fix. The securityfs hostPath made CONFIG_SECURITYFS a hard requirement on every node: the CRI runtime creates a mount source before it binds it, sysfs refuses the mkdir, and calico-node never started on a kernel built without it, taking pod networking down across the node.

CreateContainerError: failed to generate container spec: failed to mkdir
"/sys/kernel/security": mkdir /sys/kernel/security: operation not permitted

securityfs is a kernel pseudo-filesystem with a single instance, so Felix now mounts it read-only into its own mount namespace for the one kernel-lockdown read and unmounts it afterwards: projectcalico/calico#14018. The host mount is no longer needed, so this reverts #4992 exactly. Targets release-v1.44, the operator branch for Calico v3.33; on Calico master the operator lives in the calico repo and gets the same change in projectcalico/calico#14018.

Affects calico-node on operator installs of both Calico and Calico Enterprise. Reported upstream as projectcalico/calico#13681, found while raising Minikube's default CNI to Calico v3.32.2.

Release Note

Fix calico-node failing to start on nodes whose kernel is built without CONFIG_SECURITYFS.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

Copilot AI lite review requested due to automatic review settings September 22, 2026 17:19
@tomastigera
tomastigera requested a review from a team as a code owner September 22, 2026 17:19
@marvin-tigera marvin-tigera added this to the v1.45.0 milestone Sep 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

The hostPath made CONFIG_SECURITYFS a hard requirement on every node:
the CRI runtime creates a mount source before binding it, sysfs refuses
the mkdir, and calico-node never started on a kernel built without it.

Felix now mounts securityfs itself for the kernel lockdown read, in its
own mount namespace, so no host mount is needed.

CORE-13519
Copilot AI review requested due to automatic review settings September 23, 2026 16:31
@tomastigera
tomastigera force-pushed the tomas/securityfs-self-mount branch from 8479014 to 87361a3 Compare September 23, 2026 16:31
@tomastigera tomastigera changed the title node: drop the securityfs hostPath from calico-node [release-v1.44] node: drop the securityfs hostPath from calico-node Sep 23, 2026
@tomastigera
tomastigera changed the base branch from master to release-v1.44 September 23, 2026 16:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants