Repository navigation
Derive CNI address families from workload-capable IP pools - #5322
Closed
caseydavenport wants to merge 1 commit into
Closed
caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
An IPv6 pool restricted to other uses was enough to turn on assign_ipv6 for every pod, which fails on a single-stack IPv4 cluster.
Member
Author
|
Wrong repo - operator master lives in projectcalico/calico since the monorepo import. Reopening against operator/pkg/render there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix. The address families in the rendered CNI config came from every enabled IP pool in the cluster, whatever that pool was allowed to be used for:
A pool that serves only tunnels or load balancers says nothing about what an ordinary pod can get, so the CNI config now takes its address families from pools that allow
Workload. A pool with no allowed uses set still counts, matching the documented back-compatibility default. The same filter applies to host-local, which picks single or dual stack ranges off the same list.Unit tests in
pkg/rendercover both IPAM plugins, including the case where the only pool of a family is reserved for another use.AI assistance: Claude Code wrote the fix and the tests. I reviewed it and am responsible for it.
Related: CORE-13664
Release Note