Repository navigation
Auto: sync versions [master] - #5297
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
marvin-tigera
approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are straightforward, compile-time safe embed wrappers with only minor naming clarity nits identified.
Pull request overview
This PR is an automated make gen-versions sync into master, adding small Go helper packages that embed generated Calico / Enterprise CRD YAMLs and admission policy YAMLs so other code can consume them via fs.FS.
Changes:
- Add
embed.gohelpers for Calico and Enterprise CRD directories (v1.crd.projectcalico.organdv3.projectcalico.org). - Add
embed.gohelpers for Calico and Enterprise admission policy YAML directories.
File summaries
| File | Description |
|---|---|
| pkg/imports/crds/enterprise/v3.projectcalico.org/embed.go | Embeds Enterprise v3 projectcalico.org CRD YAMLs and exposes them via FS(). |
| pkg/imports/crds/enterprise/v1.crd.projectcalico.org/embed.go | Embeds Enterprise v1 crd.projectcalico.org CRD YAMLs and exposes them via FS(). |
| pkg/imports/crds/calico/v3.projectcalico.org/embed.go | Embeds Calico v3 projectcalico.org CRD YAMLs and exposes them via FS(). |
| pkg/imports/crds/calico/v1.crd.projectcalico.org/embed.go | Embeds Calico v1 crd.projectcalico.org CRD YAMLs and exposes them via FS(). |
| pkg/imports/admission/enterprise/embed.go | Embeds Enterprise admission policy YAMLs and exposes them via FS(). |
| pkg/imports/admission/calico/embed.go | Embeds Calico admission policy YAMLs and exposes them via FS(). |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
+30
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the admission policy YAML in this directory. | ||
| func FS() fs.FS { | ||
| return crds | ||
| } |
Comment on lines
+24
to
+30
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the admission policy YAML in this directory. | ||
| func FS() fs.FS { | ||
| return crds | ||
| } |
github-actions
Bot
force-pushed
the
auto-sync-versions-master
branch
from
September 8, 2026 20:07
192df98 to
f1156f1
Compare
Contributor
|
Removing "merge-when-ready" label due to new commits |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
New embed.go files are placed inside directories that existing code embeds and iterates as YAML-only, which can cause YAML unmarshal panics at runtime.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 6
- Review effort level: Lite
Comment on lines
+24
to
+29
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the admission policy YAML in this directory. | ||
| func FS() fs.FS { | ||
| return crds |
Comment on lines
+24
to
+29
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the admission policy YAML in this directory. | ||
| func FS() fs.FS { | ||
| return crds |
Comment on lines
+24
to
+29
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the CRD YAML generated into this directory. | ||
| func FS() fs.FS { | ||
| return crds |
Comment on lines
+24
to
+29
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the CRD YAML generated into this directory. | ||
| func FS() fs.FS { | ||
| return crds |
Comment on lines
+24
to
+29
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the CRD YAML generated into this directory. | ||
| func FS() fs.FS { | ||
| return crds |
Comment on lines
+24
to
+29
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the CRD YAML generated into this directory. | ||
| func FS() fs.FS { | ||
| return crds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of versions and CRDs from Calico and Calico Enterprise into
masterviamake gen-versions.Triggered by scheduled workflow.