fix: read thousands and item price currency - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numbers the wiki writes with thousands separators were cut at the first comma, so Brain Head's experience
50,000was stored as 50. Item NPC buy prices also had no currency, so 334 items priced in Theons, Gold Tokens and similar read as gold.changes:
item.value_buy_currency, taken frompricecurrency, else the text after the price, else Gold Coinmount.price_currencyshares the currency parser, which never drops an articleParsing all 18,378 articles from one snapshot with main and with this branch changes only the comma values and adds the new column.