Build on the toolchain Forge is actually built with - #31
Merged
Merged
Conversation
Three things the newer compiler here accepted and macos-14 did not. Hashable on a redaction candidate was synthesised over a CGRect, which not every toolchain will hash. Identity is the id anyway, so it is hashed and compared by id. The pressure monitor's callback read a weak self from inside the task it starts, which is a mutable reference read twice. Bound once, strongly, the way the rest of the app does it. And making a thumbnail touches no shared state, so it does not belong to the main actor - the redaction sheet reads it from a layout closure, which is not on any actor. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018H9CZxWumc3ryumgEHd578
…uage The build runner is headless: Vision fails there with "Could not create inference context", and Natural Language has no name model to answer with. Both were being read as Forge getting it wrong. The half that must always hold is kept and still asserted - a size is not a person, and calling it one would put a black box over the wrong thing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018H9CZxWumc3ryumgEHd578
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maincompiles here and does not compile onmacos-14, which is what CI uses. Three errors, all mine, all from a newer compiler being more permissive:HashableonRedactionCandidatewas synthesised over aCGRect. Identity is the id anyway, so it is hashed and compared by id.selffrom inside the task it starts — a mutable reference read twice. Bound once, strongly, the wayAppModelalready does it.Test plan
swift test— 346 green locallyswift build -Xswiftc -strict-concurrency=complete— no warnings in the new files🤖 Generated with Claude Code
https://claude.ai/code/session_018H9CZxWumc3ryumgEHd578