Move downloading of data dependencies - #3616
Closed
peterebden wants to merge 2 commits into
Closed
peterebden wants to merge 2 commits into
peterebden wants to merge 2 commits into
Conversation
Collaborator
Author
|
Wrong branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens too early now in
remote.go. Move it out ofBuild()so that function just builds and doesn't download (handling a TODO in there) and trigger the downloads externally. This actually simplifies quite a bit since we have the same "walk all inputs" inDownloadInputsIfNeededand we don't need to repeat that.Added a test case for
rex_testsince that wasn't covering this super well. It's a bit fiddly though since it's quite timing-oriented.