Skip to content

audio: module_adapter: clear pipeline back-pointers on create failure #11158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmleman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audio: module_adapter: clear pipeline back-pointers on create failure #11158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/audio/module_adapter/module_adapter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,21 @@ struct comp_dev *module_adapter_new_ext(const struct comp_driver *drv,
if (dev->task)
schedule_task_free(dev->task);
#endif
/* When module_init is called in this function, it can store this dev in its pipeline.
* This happens in the case of the copier (copier_dai_init and copier_host_create).
* The pointers remain set even after a failure. The dev is freed below on this
* creation-failure path before it was added to the IPC component list, so ipc_comp_free()'s
* back-pointer cleanup will never run for it. Clear the stale references now to prevent
* a later use-after-free when the pipeline is prepared or triggered.
*/
if (dev->pipeline) {
if (dev->pipeline->source_comp == dev)
dev->pipeline->source_comp = NULL;
if (dev->pipeline->sink_comp == dev)
dev->pipeline->sink_comp = NULL;
if (dev->pipeline->sched_comp == dev)
dev->pipeline->sched_comp = NULL;
}
module_adapter_mem_free(mod);
return NULL;
}
Expand Down
Loading