Skip to content

Trace - make clear that trace context is unused with Zephyr #11102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyakh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Trace - make clear that trace context is unused with Zephyr #11102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e51e411
audio, drivers: srop trace contexts under Zephyr
lyakh Aug 17, 2026
2336e0e
audio, ipc: stop copying trace context on Zephyr builds
lyakh Aug 17, 2026
91790f3
trace: annotate remaining DECLARE_TR_CTX calls
lyakh Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/audio/aria/aria.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */

@kv2019i kv2019i Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused if not CONFIG_TRACE, not really related to Zephyr...

@lyakh lyakh Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does a Zephyr build with CONFIG_TRACE=y do? Does this make any sense? Is ever used? Maybe make CONFIG_TRACE depend on !ZEPHYR_SOF_MODULE?

@kv2019i kv2019i Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh sof-logger with Zephyr. We used that in the past, but no longer used on Intel platforms. If this is no longer needed, we can remove the whole sof-logger from tree. I think this should be a separate PR and get all stakeholders to review the removal.

@lyakh lyakh Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i sof-logger needs CONFIG_TRACE?

@kv2019i kv2019i Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh It's right in the Kconfig description for CONFIG_TRACE:

config TRACE
»       bool "Trace"
»       default n if ZEPHYR_SOF_MODULE
»       default y
»       help
»         Enable SOF DMA based traces compatible with the sof-logger tool.

This is the option to enable sof-logger compatible trace generation from FW.

@kv2019i kv2019i Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh It doesn't seem to be used by anyone anymore (at least with Zephyr), so maybe we can remove sof-logger (tools and FW-side infra). This should be a separate PR though:

work/sof$ grep -r CONFIG_TRACE app
app/prj.conf:CONFIG_TRACE=n
app/boards/acp_7_x_adsp.conf:CONFIG_TRACE=n
app/boards/intel_adsp_ace15_mtpm.conf.orig~:CONFIG_TRACE=n
app/boards/imx8mp_evk_mimx8ml8_adsp.conf:CONFIG_TRACE=n
app/boards/intel_adsp_ace40_nvls.conf:CONFIG_TRACE=n
app/boards/intel_adsp_ace40_nvl.conf:CONFIG_TRACE=n
app/boards/acp_7_0_adsp.conf:CONFIG_TRACE=n
app/prj.conf.orig:CONFIG_TRACE=n

In src/arch/xtensa/configs/ we still have usage (at least with @thesofproject/amd targets, most recent additions in Apr 2026). A separate PR (to remove sof-logger and CONFIG_TRACE) would be good so people get a chance to review.

@lyakh lyakh Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i ah, I might be confusing names then. In the same Kconfig:

          With Zephyr, RTOS side events are not seen in the SOF trace, so native
          Zephyr logging (CONFIG_ZEPHYR_LOG) is recommended instead.

so, trace was before Zephyr and Zephyr never (or only very briefly as I seem to recall) displayed trace_point() messages like

sof/src/platform/intel/ace/platform.c

Line 99 in 3ebd434

trace_point(TRACE_BOOT_PLATFORM_CLOCK);
but you're saying that the tool, used to display those was still sof-logger? But sof-logger was also used with Zephyr before mtrace? Anyway, yes, would be good to remove CONFIG_TRACE too. It's just that at some point we should replace all the tr_dbg(&tr_ctx,...) calls to remove those unused contexts and that would be a large change. I guess we'll have to do it in several steps one directory at a time

@kv2019i kv2019i Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh Ack, the names are confusing. "trace_point()" interface has not been actively used (since SOF v2.2) and has been never supported in any Zephyr build. If you grep the current sources, all implementations are no-ops for all platforms. The code has been left as this has been convenient for developers to plug in custom debugging (i.e. write trace_point to a shared SRAM location to observe early boot fails). With @lgirdwood now adding a breadcrumbs API zephyrproject-rtos/zephyr#113242 to Zephyr, something like that would be a good backend for SOF trace_point() calls as well (e.g. something that can be read from shared memory even when DSP crashes and the kernel is no longer functional).

sof-logger has been used actively and most SOF targets have used it while transitioning to Zephyr. But it's good to emphasize all platforms should eventually move to Zephyr logging as sof-logger can never capture all logs (it only sees logs from SOF side code, it cannot be used to get logging from the RTOS or drivers), so it's a transition solution at best.

DECLARE_TR_CTX(aria_comp_tr, SOF_UUID(aria_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(aria_interface, aria_uuid, aria_comp_tr);
SOF_MODULE_INIT(aria, sys_comp_module_aria_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/asrc/asrc_ipc3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

SOF_DEFINE_REG_UUID(asrc);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(asrc_tr, SOF_UUID(asrc_uuid), LOG_LEVEL_INFO);
LOG_MODULE_DECLARE(asrc, CONFIG_SOF_LOG_LEVEL);

Expand Down
1 change: 1 addition & 0 deletions src/audio/asrc/asrc_ipc4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

SOF_DEFINE_REG_UUID(asrc4);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(asrc_tr, SOF_UUID(asrc4_uuid), LOG_LEVEL_INFO);

int asrc_dai_configure_timestamp(struct comp_data *cd)
Expand Down
3 changes: 3 additions & 0 deletions src/audio/base_fw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
LOG_MODULE_REGISTER(basefw, CONFIG_SOF_LOG_LEVEL);

@kv2019i kv2019i Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"srop trace context"?


SOF_DEFINE_REG_UUID(basefw);
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(basefw_comp_tr, SOF_UUID(basefw_uuid), LOG_LEVEL_INFO);

static struct ipc4_system_time_info global_system_time_info;
Expand Down Expand Up @@ -850,7 +851,9 @@ __cold static int basefw_set_large_config(struct comp_dev *dev, uint32_t param_i

static const struct comp_driver comp_basefw = {
.uid = SOF_RT_UUID(basefw_uuid),
#ifndef __ZEPHYR__

@kv2019i kv2019i Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be reversed? I mean these are only needed in LIBRARY builds now (or are they even needed there)? Or maybe that's not accurate enough, but maybe "#ifdef CONFIG_TRACE" (i.e. a build really using sof-logger with dictionaries).

And for Zephyr, this doesn't cover the case where you build with Zephyr but disable CONFIG_ZEPHYR_LOG. I think these cases should be prevented somehow.

@lyakh lyakh Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all I want to achieve with these is that this code / data doesn't appear in "real" firmware builds made to be run on real hardware. What's the best way to achieve that - can be discussed. This one achieves the goal and passes all CI configurations, so I used it. If the PR in principle is fine, I'd take that and if needed I'd optimise it later - unless there are any real configurations that this is breaking

@kv2019i kv2019i Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, I'm good that. Not a blocking concern.

.tctx = &basefw_comp_tr,
#endif
.ops = {
.get_large_config = basefw_get_large_config,
.set_large_config = basefw_set_large_config,
Expand Down
1 change: 1 addition & 0 deletions src/audio/buffers/comp_buffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
LOG_MODULE_REGISTER(buffer, CONFIG_SOF_LOG_LEVEL);

SOF_DEFINE_REG_UUID(buffer);
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(buffer_tr, SOF_UUID(buffer_uuid), LOG_LEVEL_INFO);

static size_t comp_buffer_get_data_available(struct sof_source *source)
Expand Down
1 change: 1 addition & 0 deletions src/audio/buffers/ring_buffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
LOG_MODULE_REGISTER(ring_buffer, CONFIG_SOF_LOG_LEVEL);

SOF_DEFINE_REG_UUID(ring_buffer);
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(ring_buffer_tr, SOF_UUID(ring_buffer_uuid), LOG_LEVEL_INFO);

static inline struct ring_buffer *ring_buffer_from_sink(struct sof_sink *sink)
Expand Down
3 changes: 3 additions & 0 deletions src/audio/chain_dma.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ static const uint32_t max_chain_number = DT_NUM_HDA_HOST_OUT + DT_NUM_HDA_HOST_I
LOG_MODULE_REGISTER(chain_dma, CONFIG_SOF_LOG_LEVEL);

SOF_DEFINE_REG_UUID(chain_dma);
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(chain_dma_tr, SOF_UUID(chain_dma_uuid), LOG_LEVEL_INFO);

/* chain dma component private data */
Expand Down Expand Up @@ -787,7 +788,9 @@ __cold static void chain_task_free(struct comp_dev *dev)

static const struct comp_driver comp_chain_dma = {
.uid = SOF_RT_UUID(chain_dma_uuid),
#ifndef __ZEPHYR__

@lgirdwood lgirdwood Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zephyr is only RTOS now. We can remove support for legacy after v2.15

@lyakh lyakh Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood these preprocessor conditionals are still needed for cmocka, testbench, maybe some other builds too.

@kv2019i kv2019i Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack on @lyakh . @lgirdwood We have no legacy targets anymore, but we do still have test targets that are not Zephyr based. Testbench, ALSA SOF plugin, cmocka -- anything where SOF is built as a library to be integrated to some host application. It's unclear whether using a full Zephyr build for these uses is meaningful (but nobody has tried yet). Cmocka is transitioning to ztest, but testbench and ALSA SOF plugin are bigger questions marks. FYI @singalsu for testbench ties and @tmleman for cmocka/ztest.

.tctx = &chain_dma_tr,
#endif
.ops = {
.create = chain_task_create,
.trigger = chain_task_trigger,
Expand Down
1 change: 1 addition & 0 deletions src/audio/channel_map.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ LOG_MODULE_REGISTER(channel_map, CONFIG_SOF_LOG_LEVEL);

SOF_DEFINE_REG_UUID(chmap);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(chmap_tr, SOF_UUID(chmap_uuid), LOG_LEVEL_INFO);

struct sof_ipc_channel_map *chmap_get(struct sof_ipc_stream_map *smap,
Expand Down
1 change: 1 addition & 0 deletions src/audio/codec/dts/dts.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(dts_tr, SOF_UUID(dts_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(dts_interface, dts_uuid, dts_tr);
SOF_MODULE_INIT(dts, sys_comp_module_dts_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ struct comp_driver_list *comp_drivers_get(void)

SOF_DEFINE_REG_UUID(component);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(comp_tr, SOF_UUID(component_uuid), LOG_LEVEL_INFO);

int comp_register(struct comp_driver_info *drv)
Expand Down
1 change: 1 addition & 0 deletions src/audio/copier/copier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,6 +1298,7 @@ static APP_SYSUSER_DATA const struct module_interface copier_interface = {
.endpoint_ops = &copier_endpoint_ops,
};

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(copier_comp_tr, SOF_UUID(copier_uuid), LOG_LEVEL_INFO);

DECLARE_MODULE_ADAPTER(copier_interface, copier_uuid, copier_comp_tr);
Expand Down
1 change: 1 addition & 0 deletions src/audio/crossover/crossover.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(crossover_tr, SOF_UUID(crossover_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(crossover_interface, crossover_uuid, crossover_tr);
SOF_MODULE_INIT(crossover, sys_comp_module_crossover_interface_init);
Expand Down
3 changes: 3 additions & 0 deletions src/audio/dai-zephyr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2067,12 +2067,15 @@ int dai_zephyr_unbind(struct dai_data *dd, struct comp_dev *dev, struct bind_inf
}
#endif /* CONFIG_IPC_MAJOR_4 */

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(dai_comp_tr, SOF_UUID(dai_uuid), LOG_LEVEL_INFO);

static const struct comp_driver comp_dai = {
.type = SOF_COMP_DAI,
.uid = SOF_RT_UUID(dai_uuid),
#ifndef __ZEPHYR__
.tctx = &dai_comp_tr,
#endif
.ops = {
.create = dai_new,
.free = dai_free,
Expand Down
1 change: 1 addition & 0 deletions src/audio/dcblock/dcblock.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(dcblock_tr, SOF_UUID(dcblock_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(dcblock_interface, dcblock_uuid, dcblock_tr);
SOF_MODULE_INIT(dcblock, sys_comp_module_dcblock_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/drc/drc_log.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

SOF_DEFINE_REG_UUID(drc);
LOG_MODULE_REGISTER(drc, CONFIG_SOF_LOG_LEVEL);
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(drc_tr, SOF_UUID(drc_uuid), LOG_LEVEL_INFO);
EXPORT_SYMBOL(log_const_drc);
#ifdef CONFIG_LOG_RUNTIME_FILTERING
Expand Down
1 change: 1 addition & 0 deletions src/audio/eq_fir/eq_fir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(eq_fir_tr, SOF_UUID(eq_fir_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(eq_fir_interface, eq_fir_uuid, eq_fir_tr);
SOF_MODULE_INIT(eq_fir, sys_comp_module_eq_fir_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/eq_iir/eq_iir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(eq_iir_tr, SOF_UUID(eq_iir_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(eq_iir_interface, eq_iir_uuid, eq_iir_tr);
SOF_MODULE_INIT(eq_iir, sys_comp_module_eq_iir_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/google/google_ctc_audio_processing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(google_ctc_audio_processing_tr, SOF_UUID(google_ctc_audio_processing_uuid),
LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(google_ctc_audio_processing_interface,
Expand Down
3 changes: 3 additions & 0 deletions src/audio/google/google_hotword_detect.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,12 +446,15 @@ static int ghd_prepare(struct comp_dev *dev)
return comp_set_state(dev, COMP_TRIGGER_PREPARE);
}

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(ghd_tr, SOF_UUID(ghd_uuid), LOG_LEVEL_INFO);

static const struct comp_driver ghd_driver = {
.type = SOF_COMP_KEYWORD_DETECT,
.uid = SOF_RT_UUID(ghd_uuid),
#ifndef __ZEPHYR__
.tctx = &ghd_tr,
#endif
.ops = {
.create = ghd_create,
.free = ghd_free,
Expand Down
1 change: 1 addition & 0 deletions src/audio/google/google_rtc_audio_processing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(google_rtc_audio_processing_tr, SOF_UUID(google_rtc_audio_processing_uuid),
LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(google_rtc_audio_processing_interface,
Expand Down
3 changes: 3 additions & 0 deletions src/audio/host-zephyr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,12 +1311,15 @@ static uint64_t host_get_processed_data(struct comp_dev *dev, uint32_t stream_no
return ret;
}

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(host_tr, SOF_UUID(host_uuid), LOG_LEVEL_INFO);

static const struct comp_driver comp_host = {
.type = SOF_COMP_HOST,
.uid = SOF_RT_UUID(host_uuid),
#ifndef __ZEPHYR__
.tctx = &host_tr,
#endif
.ops = {
.create = host_new,
.free = host_free,
Expand Down
1 change: 1 addition & 0 deletions src/audio/igo_nr/igo_nr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(igo_nr_tr, SOF_UUID(igo_nr_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(igo_nr_interface, igo_nr_uuid, igo_nr_tr);
SOF_MODULE_INIT(igo_nr, sys_comp_module_igo_nr_interface_init);
Expand Down
3 changes: 3 additions & 0 deletions src/audio/kpb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2717,12 +2717,15 @@ static int kpb_set_large_config(struct comp_dev *dev, uint32_t param_id,
}
}

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(kpb_tr, SOF_UUID(KPB_UUID), LOG_LEVEL_INFO);

static const struct comp_driver comp_kpb = {
.type = SOF_COMP_KPB,
.uid = SOF_RT_UUID(KPB_UUID),
#ifndef __ZEPHYR__
.tctx = &kpb_tr,
#endif
.ops = {
.create = kpb_new,
.free = kpb_free,
Expand Down
1 change: 1 addition & 0 deletions src/audio/level_multiplier/level_multiplier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(level_multiplier_tr, SOF_UUID(level_multiplier_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(level_multiplier_interface, level_multiplier_uuid, level_multiplier_tr);
SOF_MODULE_INIT(level_multiplier, sys_comp_module_level_multiplier_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/mfcc/mfcc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(mfcc_tr, SOF_UUID(mfcc_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(mfcc_interface, mfcc_uuid, mfcc_tr);
SOF_MODULE_INIT(mfcc, sys_comp_module_mfcc_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/mixer/mixer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ static const struct module_interface mixer_interface = {
.free = mixer_free,
};

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(mixer_tr, SOF_UUID(mixer_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(mixer_interface, mixer_uuid, mixer_tr);
SOF_MODULE_INIT(mixer, sys_comp_module_mixer_interface_init);
2 changes: 2 additions & 0 deletions src/audio/mixin_mixout/mixin_mixout.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,10 +1052,12 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(mixin_tr, SOF_UUID(mixin_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(mixin_interface, mixin_uuid, mixin_tr);
SOF_MODULE_INIT(mixin, sys_comp_module_mixin_interface_init);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(mixout_tr, SOF_UUID(mixout_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(mixout_interface, mixout_uuid, mixout_tr);
SOF_MODULE_INIT(mixout, sys_comp_module_mixout_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/module_adapter/library/userspace_proxy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ LOG_MODULE_REGISTER(userspace_proxy, CONFIG_SOF_LOG_LEVEL);
/* 6f6b6f4b-6f73-7466-20e1e62b9779f003 */
SOF_DEFINE_REG_UUID(userspace_proxy);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(userspace_proxy_tr, SOF_UUID(userspace_proxy_uuid), LOG_LEVEL_INFO);

static const struct module_interface userspace_proxy_interface;
Expand Down
1 change: 1 addition & 0 deletions src/audio/module_adapter/module/cadence_ipc3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

SOF_DEFINE_REG_UUID(cadence_codec);
LOG_MODULE_DECLARE(cadence_codec, CONFIG_SOF_LOG_LEVEL);
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(cadence_codec_tr, SOF_UUID(cadence_codec_uuid), LOG_LEVEL_INFO);

int cadence_codec_resolve_api(struct processing_module *mod)
Expand Down
1 change: 1 addition & 0 deletions src/audio/module_adapter/module/cadence_ipc4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

SOF_DEFINE_REG_UUID(cadence_codec);
LOG_MODULE_DECLARE(cadence_codec, CONFIG_SOF_LOG_LEVEL);
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(cadence_codec_tr, SOF_UUID(cadence_codec_uuid), LOG_LEVEL_INFO);

int cadence_codec_resolve_api(struct processing_module *mod)
Expand Down
1 change: 1 addition & 0 deletions src/audio/module_adapter/module/dolby/dax.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(dolby_dax_audio_processing_tr, SOF_UUID(dolby_dax_audio_processing_uuid),
LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(dolby_dax_audio_processing_interface, dolby_dax_audio_processing_uuid,
Expand Down
1 change: 1 addition & 0 deletions src/audio/module_adapter/module/passthrough.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ static const struct module_interface passthrough_interface = {
.free = passthrough_codec_free
};

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(passthrough_tr, SOF_UUID(passthrough_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(passthrough_interface, passthrough_uuid, passthrough_tr);
SOF_MODULE_INIT(passthrough, sys_comp_module_passthrough_interface_init);
1 change: 1 addition & 0 deletions src/audio/module_adapter/module/waves/waves.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(waves_tr, SOF_UUID(waves_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(waves_interface, waves_uuid, waves_tr);
SOF_MODULE_INIT(waves, sys_comp_module_waves_interface_init);
Expand Down
1 change: 1 addition & 0 deletions src/audio/multiband_drc/multiband_drc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,7 @@ SOF_LLEXT_BUILDINFO;

#else

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(multiband_drc_tr, SOF_UUID(multiband_drc_uuid), LOG_LEVEL_INFO);
DECLARE_MODULE_ADAPTER(multiband_drc_interface, multiband_drc_uuid, multiband_drc_tr);
SOF_MODULE_INIT(multiband_drc, sys_comp_module_multiband_drc_interface_init);
Expand Down
2 changes: 2 additions & 0 deletions src/audio/mux/mux_ipc3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@ LOG_MODULE_DECLARE(muxdemux, CONFIG_SOF_LOG_LEVEL);

SOF_DEFINE_REG_UUID(mux);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(mux_tr, SOF_UUID(mux_uuid), LOG_LEVEL_INFO);

SOF_DEFINE_REG_UUID(demux);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(demux_tr, SOF_UUID(demux_uuid), LOG_LEVEL_INFO);

static int mux_set_values(struct processing_module *mod)
Expand Down
2 changes: 2 additions & 0 deletions src/audio/mux/mux_ipc4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ LOG_MODULE_DECLARE(muxdemux, CONFIG_SOF_LOG_LEVEL);

SOF_DEFINE_REG_UUID(mux4);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(mux_tr, SOF_UUID(mux4_uuid), LOG_LEVEL_INFO);

SOF_DEFINE_REG_UUID(demux);

/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(demux_tr, SOF_UUID(demux_uuid), LOG_LEVEL_INFO);

static int build_config(struct processing_module *mod, struct mux_data *cfg)
Expand Down
1 change: 1 addition & 0 deletions src/audio/nxp/eap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

LOG_MODULE_REGISTER(nxp_eap, CONFIG_SOF_LOG_LEVEL);
SOF_DEFINE_REG_UUID(nxp_eap);
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(nxp_eap_tr, SOF_UUID(nxp_eap_uuid), LOG_LEVEL_INFO);

#define NXP_EAP_DEFAULT_MAX_BLOCK_SIZE 480
Expand Down
1 change: 1 addition & 0 deletions src/audio/phase_vocoder/phase_vocoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ LOG_MODULE_REGISTER(phase_vocoder, CONFIG_SOF_LOG_LEVEL);
/* Creates the component trace. Traces show in trace console the component
* info, warning, and error messages.
*/
/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(phase_vocoder_tr, SOF_UUID(phase_vocoder_uuid), LOG_LEVEL_INFO);

#if STFT_DEBUG
Expand Down
4 changes: 4 additions & 0 deletions src/audio/pipeline/pipeline-graph.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ LOG_MODULE_REGISTER(pipe, CONFIG_SOF_LOG_LEVEL);

SOF_DEFINE_REG_UUID(pipe);

@kv2019i kv2019i Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the "!CONFIG_SOF_USERSPACE_LL" in the commit message?

@lyakh lyakh Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i see the last hunk in this commit


/* unused with Zephyr, generates no output */
DECLARE_TR_CTX(pipe_tr, SOF_UUID(pipe_uuid), LOG_LEVEL_INFO);

/* number of pipeline stream metadata objects we export in mailbox */
Expand Down Expand Up @@ -140,12 +141,15 @@ struct pipeline *pipeline_new(struct k_heap *heap, uint32_t pipeline_id, uint32_
p->pipeline_id = pipeline_id;
p->status = COMP_STATE_INIT;
p->trigger.cmd = COMP_TRIGGER_NO_ACTION;
#ifndef __ZEPHYR__
/* Zephyr's tr_*() macros ignore the trace context, no need to copy it */
ret = memcpy_s(&p->tctx, sizeof(struct tr_ctx), &pipe_tr,
sizeof(struct tr_ctx));
if (ret < 0) {
pipe_err(p, "failed to copy trace settings");
goto free;
}
#endif

ret = pipeline_posn_offset_get(&p->posn_offset);
if (ret < 0) {
Expand Down
Loading
Loading