Fix - Search block input renders taller than its Search button - #148
Open
rajatgautam755421 wants to merge 1 commit into
Open
rajatgautam755421 wants to merge 1 commit into
rajatgautam755421 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QA suite — refused, no regression specThis PR changes product source but adds no spec, so the suite was Source files changed with no matching spec |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scoped fix is consistently applied across source and compiled stylesheets with no unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Fixes the Search block’s stretched input by removing the inherited bottom margin from its button.
Changes:
- Adds a scoped Search block button margin reset.
- Updates source Sass and compiled LTR/RTL stylesheets.
| File | Change |
|---|---|
style.css |
Compiled LTR CSS fix |
style-rtl.css |
Compiled RTL CSS fix |
assets/scss/_theme-style.scss |
Source Sass override |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Free-theme part of themegrill/spacious-pro#152. Pro PR: themegrill/spacious-pro#194.
The theme's global
button { margin-bottom: 30px; }also hits the core Search block's button. Inside the block's flex row that margin makes the row 30px taller, and the input stretches to fill it. So the input renders at 75px next to a 45px button.This adds
.wp-block-search__button { margin-bottom: 0; }right after the globalbuttonrule, inassets/scss/_theme-style.scssand the compiledstyle.css/style-rtl.css. The compiled rule is byte-identical to what the gulp Sass settings produce.The selector is limited to the Search block button.
.wp-element-buttonwas left out on purpose: it also matches File, WooCommerce and other block buttons, which would change their spacing on existing sites.Effect on existing sites
<button>(comment form, WooCommerce, widgets) keeps its 30px margin.How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry
Fix - Search block input renders taller than its Search button.
Verification (WordPress 7.1.2, theme 1.9.12, 1366px and 375px)
Screenshots (1366px, Search block test page + sidebar Search widget)
🤖 Generated with Claude Code