Conversation
…operator-precedence bug
QA suite — refused, no regression specThis PR changes product source but adds no spec, so the suite was Source files changed with no matching spec |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The conditional fix addresses the reported issue without changing enabled-slider behavior.
Review effort: Lite
Findings: None
What changed in this PR
Fixes slider scripts loading when the slider is disabled on the blog index.
Changes:
- Corrects operator precedence in the enqueue condition.
- Preserves loading when the slider is enabled.
| File | Description |
|---|---|
inc/enqueue-scripts.php |
Corrects slider script enqueue gating. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Fixes #145. On the homepage/blog index, two slider-related script files were loading every time, even when the "Activate Slider" setting in the Customizer was turned off. This did not cause the slider itself to show up when it should not (that part was already working correctly), it just meant a small amount of unused JavaScript was being downloaded on every visit to the homepage under the default "Your latest posts" setting. This fix makes those scripts load only when the slider setting is actually turned on, matching how Spacious Pro already does it.
How to test the changes in this Pull Request:
Types of changes:
Other information:
Changelog entry
Fix - Slider scripts loaded on the homepage even when the slider setting was off.