Skip to content

Add - ClaudeGrill QA setup - #83

Merged
iamprazol merged 5 commits into
masterfrom
add/claudegrill-qa-setup
Sep 24, 2026
Merged

iamprazol merged 5 commits into
masterfrom
add/claudegrill-qa-setup

Conversation

@iamprazol

Copy link
Copy Markdown
Contributor

Sets up the theme for ClaudeGrill QA.

  • Add .themegrill-qa/ suite manifest and knowledge file
  • Add Playwright config and initial e2e specs (smoke, accessibility, performance)
  • Add qa-suite.yml GitHub Actions workflow
  • Update package.json / lockfile and .gitignore

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

QA suite — passed ✅

All 1 checks passed.

0 passed · 0 failed · 1 skipped · 0 flaky · 0s

Automated check — no AI involved. It runs the tests in this branch.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The blocking workflow includes known-failing tests, and the suite scoping and Node/npm compatibility require correction.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 4 High severity · 3 Medium severity

Open (7)
What changed in this PR

Sets up ClaudeGrill QA for Accelerate with Playwright tests and GitHub Actions integration.

Changes:

  • Added smoke, accessibility, and performance E2E specs.
  • Added Playwright configuration, dependencies, and lockfile.
  • Added QA metadata, documentation, workflow, and ignore rules.
File Summary
tests/​e2e/​specs/​smoke/​homepage-loads-clean.spec.ts Homepage smoke coverage.
tests/​e2e/​specs/​performance/​font-awesome-single-bundle.spec.ts Font Awesome request guard; currently expected to fail and should assert exactly one request.
tests/​e2e/​specs/​accessibility/​search-form-accessible-label.spec.ts Search accessibility coverage; currently expected to fail and should use Playwright’s accessible-name assertion.
tests/​e2e/​specs/​accessibility/​mobile-menu-keyboard-navigation.spec.ts Mobile keyboard navigation coverage; currently expected to fail in the blocking tier.
playwright.config.ts Playwright runner configuration.
package.json Playwright dependency and E2E script; declared Node support is incompatible with the resolved dependency.
package-lock.json Dependency lockfile update; lockfile version conflicts with the advertised npm support.
.themegrill-qa/​suite.json QA suite manifest; lacks source-path area mappings for changed scoping.
.themegrill-qa/​knowledge.md Theme QA knowledge and known issues.
.gitignore QA artifact and credential exclusions.
.github/​workflows/​qa-suite.yml QA workflow; runs known-failing fresh tests and does not provide effective changed scoping.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/qa-suite.yml
Comment thread tests/e2e/specs/accessibility/search-form-accessible-label.spec.ts Outdated
Comment thread tests/e2e/specs/performance/font-awesome-single-bundle.spec.ts Outdated
Comment thread .themegrill-qa/suite.json
Comment thread package.json
Comment thread tests/e2e/specs/performance/font-awesome-single-bundle.spec.ts Outdated
@iamprazol

Copy link
Copy Markdown
Contributor Author

@tg-autopilot review
@claudegrill suite

@iamprazol

Copy link
Copy Markdown
Contributor Author

@claudegrill suite

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical workflow secret forwarding and multiple coverage, mapping, and test reliability issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
Resolved since last review (7)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Validate the input using its computed accessible name

tests/​e2e/​specs/​accessibility/​search-form-accessible-label.spec.ts:31

This assertion only checks input.labels[0].textContent or aria-label, so it rejects other valid accessible-name mechanisms such as aria-labelledby and can also treat an empty first label as the whole result. Use Playwright's accessible-name matcher here so the regression test validates the browser's computed accessible name rather than a partial approximation.

Comment thread .github/workflows/qa-suite.yml
Comment thread .themegrill-qa/suite.json Outdated
@iamprazol
iamprazol merged commit 8b6c3c5 into master Sep 24, 2026
@iamprazol
iamprazol deleted the add/claudegrill-qa-setup branch September 24, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants