fix: close the four defects feedback issue #194 reported in code-review and research - #209
Merged
Merged
Conversation
…ew and research
…research dispatch
mxriverlynn
marked this pull request as ready for review
September 10, 2026 14:06
This was referenced Sep 10, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback issue #194 reported four runs where a Han skill confirmed a reference existed without confirming it pointed at the right thing, or produced a complete-looking report without saying what it had not done. Three were in
code-reviewand one inresearch. This change makes both skills say what they did not do, and check that a reference supports the thing it is attached to.What changed:
code-reviewgains a named manual-only mode, entered when the dispatch mechanism fails (not when an agent returns nothing). The manual review sweeps mapped checklist categories in the absent agents' place, the report gains a## Review Coveragesection that renders only when coverage was absent, and the closing message names the cause and the count. The independent validation pass skips in that mode because it dispatches an agent.Packaging (when applicable)checklist category fires on diffs that change what gets packaged. It raises a Warning saying the review did not open the built artifact and what to check by hand. Its summary row opens withNot checked —.research's traceability invariant is now two-part (resolvability and support), defined once in Operating Principles and cited elsewhere. The merge step records an old-to-new mapping across the renumbering, rewrites every citation surface through it including the evidence-status field, and labels a claim whose only source was dropped as no-evidence rather than single-source. Both inline column enumerations now name the one-line summary column.post-code-review-to-prcarries Review Coverage across to the pull request and exempts it from the clarity pass's length-matching, so the disclosure survives to the widest audience.code-review,research, andpost-code-review-to-prupdated to match.The plan and its artifacts are under
docs/plans/code-review-research-feedback-issue-194/. Two departures from the issue are recorded there as the operator's decision: the packaging finding discloses the gap rather than inspecting the artifact, and the location rule fires on the region-read path rather than on disassembler output the skill never reads.Closes #194.