Repository navigation
chore(lint): clear all eslint warnings - #6
Merged
Merged
Conversation
Fix the 128 code warnings reported by gulp lint with minimal, behaviour-preserving edits: strict equality, no parameter reassignment, explicit return types on exported functions, flattened promise chains, and reduce/for-index/nested-ternary rewrites. Loops that are retry, polling, or order-dependent keep their sequential await behind a no-await-in-loop disable with a reason. Add the 28 existing file names that fail unicorn/filename-case to the rule's ignore list rather than renaming them.
Add a CI workflow that runs lint, build, unit tests and localization tests on pushes to master and on pull requests. Bump checkout, setup-node and upload-artifact to v7 in both workflows and let Dependabot keep GitHub Actions up to date weekly.
The test suites activate the extension through its dist/rn-extension entry point, which only the webpack production build produces. Run gulp prod-build before the dev build, matching upstream's validation pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run lintwent from 156 warnings to 0.eqeqeq: strict equality;nullcomparisons keep theundefinedcase where the type allows it.no-param-reassign: parameter renamed and aliased with oneletso bodies are unchanged.no-await-in-loop: 15 loops that are retry, polling, or order-dependent keep their sequentialawaitbehind a disable comment with a reason. No loop was made concurrent.promise/no-nesting: Android container utility flattened to async/await with the same fallback and rethrow behaviour.reduce, index loops, if/else assignments, unused params, and missing return types on exported functions rewritten mechanically.unicorn/filename-case(28): the existing file names are added to the rule'signorelist in.eslintrc.jsinstead of being renamed, to avoid case-only renames and upstream merge churn.Verification
npm run lint: 0 problemstsc --noEmit: cleannpm run build: successnpm test: 473 passing