Repository navigation
Document installing in VSCodium, and mark local builds as patched - #3
Merged
Merged
Conversation
The extension keeps upstream's msjsdiag.vscode-react-native id, so a patched local build was indistinguishable from the published one in the extensions list. Rename the display name, and put the build date in the patch version. 1.14.<YYYYMMDD> keeps the upstream base visible, always sorts above a real 1.14.x, and rises on every build without being managed by hand. An upstream 1.15.0 would sort above it, which is the point at which this fork wants rebasing anyway. npm run install-local now stamps the date before packaging, so every local install carries the day it was built. It writes package.json and the lockfile, so expect a dirty tree after a local build. Drop this commit before opening a pull request upstream.
VSCodium resolves extensions from Open VSX, which does not carry this fork, so the packaged VSIX has to be installed directly. Cover both routes: the VSIX attached to a release by CI, and a local build via npm run install-local. Also record how a local build is told apart from the published extension, and that auto update has to be disabled because the fork keeps upstream's extension identifier. Drop this commit before opening a pull request upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an Install in VSCodium section to the README, after Package extension locally, with a matching table-of-contents entry.
Covers both install routes — the VSIX that CI attaches to a
v*release, and a local build throughnpm run install-local— plus how a local build is distinguished from the published extension, and why auto update needs disabling (the fork keeps upstream'smsjsdiag.vscode-react-nativeidentifier).Also carries the version-scheme commit, which missed #2 because that PR was merged first: display name becomes React Native Tools (patched) and the version becomes
1.14.<YYYYMMDD>, stamped automatically byinstall-local.Validation
npx prettier --check README.mdpassesgh release downloadcommand was run against the live release and fetchedvscode-react-native-1.14.2.vsixnpm run install-localwas run end to end; VSCodium listsmsjsdiag.vscode-react-native@1.14.20260928as React Native Tools (patched), with all three debugger fixes present in the bundle