Fix: remove cert-manager subchart dependency - #575
Open
niyomukiza-mechack wants to merge 1 commit into
Open
Conversation
niyomukiza-mechack
requested review from
a team,
eniko-dif and
jlegrone
as code owners
September 8, 2026 20:28
tomba7
approved these changes
Sep 10, 2026
| # install controls whether cert-manager is installed as a Helm subchart. | ||
| # Set to true if cert-manager is not already installed in the cluster. | ||
| # See https://cert-manager.io/docs/installation/ | ||
| install: false |
Collaborator
There was a problem hiding this comment.
Since this field is going away, it would be worth updating the following sites where its still referenced:
README.md:80
docs/worker-resource-templates.md:94
internal/demo/README.md:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Removed the embedded cert-manager subchart dependency from the TWC Helm chart.
Files changed:
Chart.yaml - removed the dependencies: block that declared cert-manager as a conditional subchart
Chart.lock - deleted (no more dependencies to lock)
values.yaml - removed certmanager.install and updated the enabled comment to say "installed independently" instead of "via the subchart above or separately"
Makefile - removed the helm dependency build target and its prerequisites from test-all and test-unit (no subchart to fetch anymore)
skaffold.yaml - removed certmanager.install: false from the TWC setValues (the value no longer exists)
Why?
Cert-manager manages cluster-wide resources that should be installed once per cluster, not bundled inside another chart's Helm release.
Checklist
Closes
How was this tested: