Skip to content

Retry schedule updates on conflict token mismatch - #1812

Open
ningmao-hlyz wants to merge 1 commit into
temporalio:mainfrom
ningmao-hlyz:schedule-conflict-token-retry
Open

Retry schedule updates on conflict token mismatch#1812
ningmao-hlyz wants to merge 1 commit into
temporalio:mainfrom
ningmao-hlyz:schedule-conflict-token-retry

Conversation

@ningmao-hlyz

Copy link
Copy Markdown

What changed

  • Pass the schedule describe response conflict token into update schedule requests.
  • Retry the describe/update loop when the server reports a mismatched conflict token.
  • Add a unit test covering the retry path and conflict token propagation.

Fixes #1367

Checks

  • uv run pytest tests/test_client.py::test_schedule_update_retries_conflict_token
  • uv run ruff check --select I temporalio/client/_impl.py tests/test_client.py
  • uv run ruff format --check temporalio/client/_impl.py tests/test_client.py
  • uv run pyright temporalio/client/_impl.py tests/test_client.py
  • git diff --check

@ningmao-hlyz
ningmao-hlyz requested a review from a team as a code owner September 3, 2026 12:22
@CLAassistant

CLAassistant commented Sep 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ningmao-hlyz
ningmao-hlyz force-pushed the schedule-conflict-token-retry branch from cc5b2a8 to f238dd7 Compare September 7, 2026 14:18
@ningmao-hlyz

ningmao-hlyz commented Sep 7, 2026

Copy link
Copy Markdown
Author

Hi maintainers. The change passes the focused schedule conflict-token test and local Ruff, Ruff format, Pyright, BasedPyright, Mypy, pydocstyle, and diff checks. Could someone review the PR when convenient? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[python] Support conflict token retry loop for schedule updates

2 participants