iris-gui: move the jitv2 persistent code cache toggle to the General tab - #171
Merged
techomancer merged 1 commit intoOct 2, 2026
Merged
Conversation
It was on the Debug tab, which Tab::visible hides entirely in lightning builds (build_features::LIGHTNING) — but jitv2's persistent cache is an independent feature from lightning, so a lightning+jitv2 build had no way to reach the checkbox at all. General is always visible. Dropped the "not built" fallback label when jitv2 isn't compiled in — the General tab doesn't otherwise narrate build features inline, so this now just omits the section silently, same as the rest of the tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cfg.jitv2.cache/cache_dir) on the Debug tab.Tab::visiblehides the Debug tab entirely in lightning builds (build_features::LIGHTNING) — but jitv2's persistent cache is an independent cargo feature fromlightning, so alightning,jitv2build (e.g. the "Premiere" profile with jitv2 added) had no UI path to the toggle at all.build_features::JITV2so it only appears in jitv2 builds.Test plan
cargo check -p iris-gui --features iris/jitv2cargo check -p iris-gui(default, no jitv2)cargo check/cargo check --features jitv2(CLI crate, unaffected but re-verified)