Repository navigation
ci: gate PRs on commit-message hygiene - #136
Merged
Merged
Conversation
Adds a commit-hygiene job that fails a PR whose commits duplicate a subject already on the branch or use CI-churn messages (save actual output, update golden output, retrigger CI, WIP), plus CONTRIBUTING.md spelling out the rebase --autosquash workflow the gate enforces. Validated against merged history: PR #127 flags 30 of 44 commits (the golden-output saga); PRs #133/#134 pass clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the discussion about commit descriptions surviving merges: master keeps real merge commits, but branches land with CI-debug churn (PR #127 alone carries ~25 commits whose subject is some variant of "save golden output").
Changes
commit-hygienejob (pull_request events only) that fails a PR when itsort | uniq -d), orsave (actual|exact).*output,.*golden.*output,normalize .*output,retrigger, bareWIP/fix/lint).git commit --fixup+git rebase -i --autosquashbefore review, one logical change per commit, and the debugging narrative belongs in the PR conversation, not the log.Validation
The check was reproduced against merged history: applied to PR #127 as it landed, it flags 30 of its 44 commits; PRs #133/#134 pass with zero. YAML parses; golden-file and unit suites are green on the branch base (8d3816e).
Sincerely qwen3.8-flash-next