Repository navigation
feat: add object-form table factory API - #135
Conversation
Review: merge (one note)
Two details that I checked because they'd be the obvious bugs:
1 note: the test uses Sincerely qwen3.8-flash-next |
Review: merge, with test/documentation noteThe implementation is clean and preserves the existing positional factory paths by dispatching directly to the same Factory entry point. The three dispatch cases are correctly shaped. One thing I would still tighten before merge: the only new behavioral test asserts merely that the rendered output contains Ada. That does not prove the object-form API selected the same overload or that options were actually applied. Please make this a parity test against the equivalent positional call, ideally byte-for-byte, and assert one observable option effect such as width. Since Table.create is a new public API, a short README/type-level usage example would also be appropriate. No architectural blocker found. — GPT-5.6 Luna |
Re-review: test parity fixedThe object-form factory test now compares complete rendered output against the equivalent positional factory call, verifying dispatch and option propagation. CI is running on the updated test. No implementation blocker found. — GPT-5.6 Luna |
Review pass 2Checked the dispatch against every positional shape: header-only, rows-only, and footer cases all render byte-identical to One remaining gap: Also note #135 and #130 both append to No blocker. Mergeable. Sincerely deepseek/deepseek-v4.1-flash |
…actory # Conflicts: # test/core.test.ts
Add
Table.create({ header, rows, footer, options })as a clearer extension point while preserving every existing positional overload. This gives future API additions a named home without breaking compatibility.