Skip to content

feat: add sanitized BLE connection-stage diagnostics - #145

Merged
enaboapps merged 1 commit into
mainfrom
codex/ble-stage-diagnostics-144
Sep 10, 2026
Merged

feat: add sanitized BLE connection-stage diagnostics#145
enaboapps merged 1 commit into
mainfrom
codex/ble-stage-diagnostics-144

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Closes #144.

Summary

Adds fixed-vocabulary local diagnostics for discovery GATT/status, selected-PC connection, Android priority/MTU, services, notification listener and CCCD readiness. Wires the transport to the existing Settings Diagnostics log. No native errors, addresses, payloads or credentials enter stage entries. Cancellation generation checks suppress stale outcomes; late discovery connections still receive deterministic cleanup. Existing user-facing errors and protocol behavior remain intact.

Companion diagnostic work for switchifyapp/switchify-pc#717, not Linux input/pairing support. Includes fake-native tests and S26 retest instructions. No release, version or native configuration changes in this diff. Nothing merged or installed on the phone.

Stack: #147 (approved Expo patch prerequisite) → this PR. Review against codex/expo-patch-alignment-146; diagnostics code is unchanged by the rebase. Merge only in stack order with explicit authorization.

Validation

  • Independent latest-head review of d223b96eeee88543cda79a457317de71dc732bcd: no actionable findings; reviewer independently reran the 58 focused tests after the rebase.
  • Full local npm run validate passed: version check, lint, TypeScript, all 564 tests across 65 suites and all 21 Expo Doctor checks. The earlier dependency blocker is resolved by fix: align Expo SDK 57 patch dependencies #147. Whitespace check passed.
  • All latest-head CI checks passed: validation and clean Android/iOS native builds. Physical S26 validation requires a build containing this commit and remains pending.

Do not merge or publish a release without explicit authorization.

@enaboapps
enaboapps changed the base branch from main to codex/expo-patch-alignment-146 September 10, 2026 12:29
@enaboapps
enaboapps force-pushed the codex/ble-stage-diagnostics-144 branch from 69fd1b4 to d223b96 Compare September 10, 2026 12:30
@enaboapps enaboapps added this to the v1.0.0-beta.22 milestone Sep 10, 2026
@enaboapps
enaboapps changed the base branch from codex/expo-patch-alignment-146 to main September 10, 2026 13:07
@enaboapps
enaboapps marked this pull request as ready for review September 10, 2026 13:07
@enaboapps
enaboapps merged commit 214e998 into main Sep 10, 2026
3 checks passed
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

Greptile Summary

Adds fixed-vocabulary Bluetooth connection diagnostics to the existing local log and shares that log between the Bluetooth transport and connection manager. Fake-native Android setup, failure, cancellation, and late-completion flows were exercised successfully. No defects were found.

Confidence Score: 5/5

The change is safe to merge based on exercised connection, diagnostic, sanitization, and cancellation behavior.

The focused fake-native checks exercised successful Android connection setup through notification readiness, injected MTU failure handling, and late native completions after cancellation. The repository's focused BLE and diagnostics tests and TypeScript typecheck also passed.

Files Needing Attention: No files need follow-up from this review. Physical Android and iOS device behavior remains covered by the documented device retest procedure.

T-Rex T-Rex Logs

What T-Rex did

  • Executed focused BLE diagnostic validation tests and the BLE transport/diagnostic suite; all 3 focused fake-native flows passed and all 58 tests in the broader suite passed.
  • Ran TypeScript type-checking and confirmed it completed successfully.
  • Examined MTU rejection and late-completion paths in diagnostics; MTU rejection output and late-cancellation output were produced as expected.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "feat: add sanitized BLE connection-stage..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sanitized BLE connection-stage diagnostics

1 participant