Skip to content

Clarify Controls and Cursor appearance settings tabs - #707

Merged
enaboapps merged 1 commit into
mainfrom
issue-706-settings-tab-names
Sep 8, 2026
Merged

Clarify Controls and Cursor appearance settings tabs#707
enaboapps merged 1 commit into
mainfrom
issue-706-settings-tab-names

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Rename the Pointer tab and heading to Controls, and Cursor to Cursor appearance, so users can distinguish input behavior from overlay visuals. Update the Controls description and let settings tab widths follow their content so the longer label fits.

Closes #706

Validation on Node.js 24.13.0 and Rust 1.97.1:

  • npm run lint, npm test, npm run build passed, with 108 UI/API tests and 5 update-feed tests.
  • cargo fmt --manifest-path src-tauri/Cargo.toml --check passed.
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings passed.
  • cargo test --manifest-path src-tauri/Cargo.toml passed, with 270 tests.
  • Headless Chromium layout checked at 620x520, 681x520, and 920x700. All tab labels fit their buttons. Existing panel overflow at 681px remains outside this tab-label change.

Independent agent review of e78917e found no actionable issues. Reviewed the full diff and all three layout screenshots.

@enaboapps
enaboapps marked this pull request as ready for review September 8, 2026 19:34
@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

Greptile Summary

This change renames the input settings area to Controls and the overlay settings area to Cursor appearance, with tabs sized to their content. Rendered checks confirmed that both renamed tabs remain visible, selectable, accessible, and connected to the correct panel at 620×520, 681×520, and 920×700.

A page-level horizontal scrollbar is present at 681×520 because the desktop sidebar and settings gutters exceed the available width. The same overflow is visible before and after this change, but the updated tab layout does not address it. Checks disproved that the longer Cursor appearance tab itself clips, overflows its tab bar, selects the wrong panel, or loses tab accessibility.

Confidence Score: 4/5

Do not merge without addressing the horizontal overflow at the 681px desktop boundary.

Chromium rendering reproduced page-level horizontal overflow at the affected viewport and confirmed the renamed tab interactions and accessibility behavior at all requested sizes.

Files Needing Attention: src/styles.css needs attention around the 680px responsive breakpoint and the settings view’s desktop spacing.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex produced a proof for a posted P1 finding and linked it to the corresponding review comment.
  • Chromium checks exercised the post-change tab bar across three viewport sizes and verified the renamed tabs, confirming that the tab bar stays within bounds, the active Cursor appearance tab has the correct ARIA roles, and the relevant controls appear.
  • T-Rex produced proof for a second posted P1 finding.
  • Validation results show the Cursor appearance bounds stay within the tab bar across tested viewports, the renamed tabs select the intended panels, and the active Cursor appearance tab is accessible with appropriate ARIA attributes.

View all artifacts

T-Rex Ran code and verified through T-Rex

Comments Outside Diff (1)

  1. General comment

    P1 Settings page horizontally overflows at the 681px desktop breakpoint

    • Bug
      • At 681×520, Chromium reports documentOverflow: true while the Settings view is rendered. This forces a horizontal scrollbar/page overflow at a target viewport explicitly required by this validation.
    • Cause
      • The breakpoint remains desktop above 680px, combining the fixed 210px sidebar and the view’s 42px horizontal padding; the PR’s content-sized tab rule at src/styles.css:317 does not address the resulting narrow main content area.
    • Fix
      • Move the compact/mobile layout breakpoint above 681px or reduce desktop sidebar/gutter sizing in this intermediate range; retain a tab-bar layout that fits the available main-column width.

    T-Rex Ran code and verified through T-Rex

Prompt To Fix All With AI
### Issue 1
src/styles.css:317-319
**Settings viewport overflows at the desktop breakpoint**

At a 681×520 viewport, the fixed 210px sidebar plus the desktop settings gutters leave the document wider than the viewport, producing a horizontal scrollbar. This width remains in the desktop layout because the compact layout starts only at 680px. Increase the compact-layout breakpoint or reduce the sidebar and horizontal gutters through this intermediate range so Settings fits without page-level horizontal scrolling.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "Clarify Controls and Cursor appearance s..." | Re-trigger Greptile

Comment thread src/styles.css
@enaboapps
enaboapps merged commit be2ad3d into main Sep 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Differentiate Controls and Cursor appearance settings tabs

2 participants