fix: give the Support tabs a real tablist - #702
Merged
Conversation
enaboapps
force-pushed
the
feat/update-status-off-tab-697
branch
from
September 8, 2026 15:58
bb51bf6 to
91b81ae
Compare
enaboapps
force-pushed
the
feat/support-tabs-690
branch
from
September 8, 2026 15:59
d138381 to
05f7889
Compare
enaboapps
force-pushed
the
feat/update-status-off-tab-697
branch
from
September 8, 2026 16:07
91b81ae to
72f7a75
Compare
enaboapps
force-pushed
the
feat/support-tabs-690
branch
2 times, most recently
from
September 8, 2026 16:31
d939a62 to
3fb926b
Compare
enaboapps
force-pushed
the
feat/update-status-off-tab-697
branch
from
September 8, 2026 16:31
18572e1 to
e625f4e
Compare
enaboapps
force-pushed
the
feat/support-tabs-690
branch
3 times, most recently
from
September 8, 2026 17:00
5a13234 to
0a3146a
Compare
enaboapps
changed the base branch from
feat/update-status-off-tab-697
to
main
September 8, 2026 17:17
The Support view's Setup/Troubleshooting control carried tablist roles but none of the behaviour: no roving tabindex, so both tabs were tab stops; no arrow-key movement; and no tabpanel for the content, so the roles promised a widget that was not there. Tabs and TabPanel move out of settings/ to src/Tabs.tsx, take a `name` that scopes their element ids so two tablists can share a page, and are generic over the tab id type. Support now uses them, which gives it the same single tab stop, arrow and Home/End movement with wraparound, manual activation and labelled panel as Settings. Ids for the Settings tablist are unchanged. The Support tab bar changes from an inline pair to the full-width bar Settings uses, verified in headless Chrome; the content below it is untouched. Tests: 98 -> 99. Closes #690 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
SupportView hand-wrote "setup" | "troubleshooting" in its useState while supportTabs already declared the same ids as const, so adding a tab would have compiled to a confusing error on onSelect rather than at the source of the drift. The union is now indexed off supportTabs, matching the [number] pattern App.tsx already uses. Refs #690 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review follow-ups on the Support tablist. The tab id generic stopped at Tabs: TabPanel still took any string, and SettingsView instantiated it with plain strings, so a misspelt id compiled and rendered an empty panel. TabPanel is generic too, and SettingsView names its ids as a union, so both callers are checked. tabId and panelId had no importers; they are module-private now, like descriptionId. With the last bare .segmented consumer gone, its inline-grid display, 280px minimum width and the narrow-viewport override were overridden by every remaining use and are removed; the two-column template stays for OptionGroups without a column count. Refs #690 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
enaboapps
force-pushed
the
feat/support-tabs-690
branch
from
September 8, 2026 17:17
d765125 to
9c55d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #690. Stacked on the #697 PR — base is
feat/update-status-off-tab-697.The Support view's Setup/Troubleshooting control carried
role="tablist"/role="tab"but none of the behaviour: both tabs were tab stops, arrows did nothing, and the content had notabpanel, so the roles promised a widget that was not there.What changes
Tabs/TabPanelmove fromsrc/settings/tosrc/Tabs.tsx, take anamethat scopes element ids (support-tab-setup,settings-panel-general, …) so two tablists can share a page, and are generic over the tab id type.tabindex, Arrow/Home/End with wraparound, manual activation,aria-controlson the selected tab, labelledtabpanel.settings-tabs/settings-paneltotab-bar/tab-panel.Visual
The Support tab bar changes from an inline two-button pair (
min-width: 280px) to the full-width bar Settings uses. Verified in headless Chrome; the content below is untouched.Validation
npm run lintnpm testnpm run buildNew test: Support roving tabindex, arrow-key focus without activation,
aria-controls, and the labelled panel switching on click. Headless Chrome confirmsTroubleshootingnow reportstabindex=-1while unselected (it was0before).🤖 Generated with Claude Code
Review history
SupportViewhand-wrote the"setup" | "troubleshooting"union thatsupportTabsalready declared; it is now indexed off the list.The tab id generic stopped at
Tabs;TabPanelis generic too and SettingsView names its ids as a union, so a misspelt id no longer compiles.tabId/panelIdhad no importers and are module-private now.With the last bare
.segmentedconsumer gone, itsinline-grid, 280px minimum width and narrow-viewport override were dead and are removed; the two-column template stays forOptionGroups without a column count. Verified in headless Chrome.Not changed:
nameis passed toTabsandTabPanelseparately. Binding the pair is a larger API change than this issue warrants, and Settings and Support are mutually exclusive views, so the collision it guards against is not reachable today.