Skip to content

fix(config): route Qwen3.8 grammar requests without speculation - #258

Merged
mamayer19 merged 1 commit into
mainfrom
task-qwen38-no-spec
Sep 7, 2026
Merged

fix(config): route Qwen3.8 grammar requests without speculation#258
mamayer19 merged 1 commit into
mainfrom
task-qwen38-no-spec

Conversation

@mamayer19

@mamayer19 mamayer19 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route Qwen3.8 grammar-constrained requests through an explicit no-spec profile
  • make that profile inherit the existing conservative default route
  • assert the profile is present, selected by the generation task, and resolves exactly to default

Validation

  • focused Qwen3.8 profile tests: 5 passed
  • grammar-profile and inheritance tests: 14 passed
  • repository lint and git diff --check passed

Summary by CodeRabbit

  • New Features

    • Added a no-spec generation profile for the Qwen3.8 model.
    • The default generation task now uses the no-spec profile, with settings matching the existing default profile.
  • Tests

    • Added coverage verifying the new profile and its use by the default generation configuration.

@mamayer19
mamayer19 requested a review from a team as a code owner September 7, 2026 11:37
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 8f7fbf6d-bc60-4937-a30c-99f2dd3d0699

📥 Commits

Reviewing files that changed from the base of the PR and between 2183bc1 and d3040e6.

📒 Files selected for processing (2)
  • packages/sie_server/models/Qwen__Qwen3.8-27B-FP8.yaml
  • packages/sie_server/tests/config/test_qwen38_generation_profiles.py

Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The Qwen3.8 model configuration now selects the no-spec grammar profile by default. The new profile inherits the default profile. Tests verify profile availability, resolution, selection, and configuration equivalence.

Changes

Qwen3.8 profile selection

Layer / File(s) Summary
Add and validate no-spec profile
packages/sie_server/models/Qwen__Qwen3.8-27B-FP8.yaml, packages/sie_server/tests/config/test_qwen38_generation_profiles.py
The default generation configuration selects no-spec. The profile inherits default. Tests verify profile availability, selection, and matching configuration.

Merge Risk: ⚪ Minimal · up to d3040

Qwen3.8 grammar-constrained generation now explicitly selects a no-spec route with the same conservative settings as the prior default. Coverage confirms the new profile resolves identically, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: routing Qwen3.8 grammar requests through the new no-spec profile.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task-qwen38-no-spec

Comment @coderabbitai help to get the list of available commands.

@mamayer19
mamayer19 merged commit 1c7bbe8 into main Sep 7, 2026
19 checks passed
@mamayer19
mamayer19 deleted the task-qwen38-no-spec branch September 7, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant