Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
cookies: { encode: "tokens-only" },createBrowserClient()readswindow.localStorageto choose where to store user data. That property can throw aSecurityErrorwhen browser policy blocks storage access. Client creation then fails before auth can use the cookie adapter.This catches failures when obtaining the default browser storage and uses a fresh memory adapter instead, matching the existing non-browser fallback. Accessible localStorage is still used, and an explicit
auth.userStoragetakes precedence without touching localStorage. Tokens continue to use cookie storage. The option documentation explains that fallback user data lasts only for the lifetime of the client.The regression uses a localStorage getter that throws a DOMException. It fails on the original implementation and passes with the fix. It also checks user storage read/write/removal, cookie-backed token storage, explicit userStorage, and the normal browser path.
All 123 tests pass across seven files. Both TypeScript builds, Prettier checks, and whitespace checks pass. This was tested in Node 22 with a simulated browser storage denial; a browser automation test was not run.