Repository navigation
fix: use cookieOptions.name over auth.storageKey in createServerClient - #303
Open
dasjideepak wants to merge 1 commit into
Open
dasjideepak wants to merge 1 commit into
dasjideepak wants to merge 1 commit into
Conversation
createBrowserClient lets cookieOptions.name override auth.storageKey, but createServerClient did the opposite. With both options set, the server read a different cookie than the browser wrote and found no session.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302
When both
cookieOptions.nameandauth.storageKeyare set,createBrowserClientusescookieOptions.namebutcreateServerClientusesauth.storageKey. The server then reads a different cookie than the browser wrote and gets no session. This makes the server use the same precedence as the browser.cookieOptions.nameoverride after...options?.authincreateServerClientcookieOptions.namecookie withauth.storageKeyalso set (fails before, passes after)auth.storageKey) if you prefer.