Make Windows releases reproducible and self-explanatory - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
create-local-release.ps1publish through clean stagingwin-x64-self-contained, with .NET bundledwin-x64-net10, requiring the x64 .NET 10 Desktop RuntimeClipDiff.exeandClipDiff.ShellExtension.dllv1.2.3GitHub releasesWhy
The raw
bin/publish output was easy to mistake for the distributable application, the local output directory could retain stale files, and the README contradicted itself by eventually saying to copy only the EXE. The self-contained executable is also about 188 MB because it bundles .NET; users who already have the x64 .NET 10 Desktop Runtime now get a much smaller package.The ZIPs are the release contract: choose one variant, extract both files together, and run the EXE.
Verification
The Windows workflow completed successfully. It exercised the native build/tests, .NET tests, both publishes, payload validation, and both artifact uploads. The resulting GitHub Actions artifacts are approximately 77.9 MB for self-contained and 6.8 MB for the .NET 10-dependent build.