Refine hotkey validation: disallow Windows modifier and modifier virtual keys, add VK constants and tests - #13
Open
stuartd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ShiftorAlt+F4.Description
Windowsflag fromHotKeyModifiersand stop treating the Windows modifier as supported.VirtualKey*constants and build aModifierVirtualKeysset to explicitly recognize keys that are modifiers and therefore cannot be the primary key.IsValidto require at least one primary modifier (ControlorAlt), reject unsupported modifier bits, enforce VK range bounds, exclude Windows key VKs and modifier VKs, and disallowAlt+F4.DisplayTextspecial-case and rely onIsValid, and expand/adjust unit tests inHotKeyGestureTeststo cover boundary cases and unsupported flags.Testing
tests/ClipDiff.Windows.Tests/HotKeyGestureTests.csviadotnet testfor theClipDiff.Windows.Testsproject.HotKeyGestureTestspassed successfully.Codex Task