fix: configure reflection for REST client data classes - #824
Merged
fhussonnois merged 1 commit intoSep 26, 2026
Merged
Conversation
fhussonnois
requested changes
Sep 25, 2026
fhussonnois
left a comment
fhussonnois
left a comment
Member
There was a problem hiding this comment.
Hi @jeroen92 , thanks for catching this!
We don't usually add Jikkou classes to reachability-metadata.json. We annotate them with @Reflectable instead, and JikkouRuntimeReflectionRegistrationFeature registers them at native build time. ErrorResponse, ErrorEntity and Info already have it, so only ResourceListRequest, ResourceReconcileRequest and ResourceReconcileRequest.Params were missing it.
Could you drop the JSON changes and just add @Reflectable to those three?
Thank you
ResourceListRequest, ResourceReconcileRequest and ResourceReconcileRequest.Params were missing the @reflectable annotation, causing Jackson serialization to fail (No serializer found for class ResourceListRequest).
jeroen92
force-pushed
the
jeroen/cli-serialization-errors
branch
from
September 25, 2026 10:34
baffbd8 to
4345754
Compare
Author
|
Hey, that makes a lot of sense, much nicer to do it that way indeed. I've updated the PR! |
fhussonnois
approved these changes
Sep 26, 2026
fhussonnois
left a comment
fhussonnois
left a comment
Member
There was a problem hiding this comment.
LGTM! Thank you very much for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourceListRequest lacked reflection config, causing Jackson serialization to fail (No serializer found for class io.jikkou.rest.data.ResourceListRequest).
This commit enables reflection for all publicConstructors/publicMethods for data classes used by the API client (ResourceListRequest, ResourceReconcileRequest, ResourceReconcileRequest$Params, ErrorResponse, ErrorEntity, Info).