Fix swapped Type/Description column headers in the cors middleware options table - #3509
Open
yfwmaniish wants to merge 1 commit into
Open
yfwmaniish wants to merge 1 commit into
yfwmaniish wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
corsmiddleware options table header row is labeledOption | Type | Description | Default value, but the data columns are orderedOption | Description | Type | Default— so the type (e.g.StringorArrayorFunction) currently renders under the Description column and the description under the Type column.This swaps the two header labels to
Option | Description | Type | Default value, which matches both the table's own data and the convention used by every other middleware options table on this page (body,compression, etc.). Header row only; no data rows changed.Related issue(s)/PR(s)
None — spotted while reviewing the internal middlewares configuration reference.