Repository navigation
Handle DELETE method in ReadSignals - #12
Merged
Merged
Conversation
crustyrustacean
added a commit
to crustyrustacean/datastar-rust
that referenced
this pull request
Sep 30, 2026
Align ReadSignals with the adapter contract upstream settled in starfederation#12: GET and DELETE read signals from the datastar query parameter, every other method (including QUERY) from the JSON body. A missing datastar parameter now deserializes as null instead of returning 400, so ReadSignals<Option<T>> yields None on a plain page load. DatastarParam becomes Option<serde_json::Value> to match the other adapters. Adds tests for DELETE extraction and the optional-signals behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on ADR changes in starfederation/datastar#1146.
Please merge only with the release of the next version of Datastar.