Repository navigation
Keep CocoaPods out of Capacitor's sync so the lock retry is reached - #4
Merged
Merged
Conversation
With the CocoaPods retry installed, the same IONCameraLib failure came back unchanged, because the retry never ran: Capacitor's `cap sync ios` rewrites the Podfile's plugin block and then runs `pod install` itself, in the syncing phase before buildbridge's own CocoaPods phase, and it has no switch to leave that out. Only which `pod` it runs can be chosen. The sync now runs with CAPACITOR_COCOAPODS_PATH=/usr/bin/true, so Capacitor rewrites the Podfile and cleans the project but leaves CocoaPods to the next phase, where a committed lock a plugin upgrade outgrew is updated in the guest and offered for adoption. Verified on the guest against the project with its stale lock restored: sync passes, install refuses the pod, the update resolves it, and the lock-changed marker fires.
…t was called The macOS half of CI failed the install-and-launch test with no console lines streamed, on a change to the iOS recipe. The test's stand-in for a Stop from the desktop fired as soon as the fake adb had been called with logcat, not once the run had read the two lines the fake prints, so on a slow runner the run ended before they arrived. The Stop now waits until the run's progress has carried both lines, with the same 30-second ceiling, so it lands where a person's would: after the console is visibly streaming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the CocoaPods retry installed, the same IONCameraLib failure came back unchanged. The retry never ran: Capacitor's
cap sync iosrewrites the Podfile's plugin block and then runspod installitself, in the syncing phase before buildbridge's own CocoaPods phase, and it has no switch to leave that out. Only whichpodit runs can be chosen, throughCAPACITOR_COCOAPODS_PATH.The sync now runs with that variable set to
/usr/bin/true, so Capacitor rewrites the Podfile and cleans the project but leaves CocoaPods to the next phase, where the retry lives.Verified on the macOS guest against the affected project with its stale lock restored: sync passes, install refuses the pod, the update resolves IONCameraLib 2.0.0, and the lock-changed marker fires so the test build step offers the refreshed lock for adoption. Recorded in the design record and the issue ledger.