Repository navigation
Judge the host USB rule by the lines udev reads, and let host rungs act before the build - #2
Merged
Merged
Conversation
…ct before the build On a host that had run an earlier release, the iPhone step warned that the udev rule differed from the expected content, every check showed as failed, and the reinstall button was disabled. The check compared the whole file byte for byte, and the lowercase-brand commit had changed the comment header from "Written by BuildBridge" to "Written by buildbridge". The rule line was identical, so passthrough worked while the step said it did not. The check now compares the lines udev acts on and ignores comments and blank lines, so a header change never asks a working host to reinstall, while a changed or added rule line still does. The step also disabled its primary action whenever the step was pending, whichever rung it stood on, so a host waiting on its test build could not install a udev rule that no build depends on. The pending gate now withholds only the signing and run rungs, which the engine refuses without the test build anyway, and their button says so; every host and phone rung acts at any time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a host that had run an earlier release, the iPhone step warned that the udev rule differed from the expected content, every check showed as failed, and the reinstall button was disabled.
Rule check. It compared the whole file byte for byte, and the lowercase-brand commit changed the comment header from "Written by BuildBridge" to "Written by buildbridge". The rule line was identical, so passthrough worked while the step said it did not. The check now compares the lines udev acts on and ignores comments and blank lines. A header change never asks a working host to reinstall; a changed or added rule line still does.
Pending gate. The step disabled its primary action whenever it was pending, whichever rung it stood on, so a host waiting on its test build could not install a udev rule that no build depends on. The gate now withholds only the signing and run rungs, which the engine refuses without the test build anyway, and their button names that reason. Every host and phone rung acts at any time.
Both are recorded in the design ledger. Checks run: format and lint, desktop typecheck, 402 desktop tests, machines crate tests, clippy.