Synchronise master with upstream - #589
Merged
Merged
Conversation
This adds support for the ACME dns-01 challenge while keeping http-01 the default. A new --challenge option (default http-01) selects the challenge type. When dns-01 is selected, --dns-provider names any DNS provider compiled into the bundled lego binary, and an optional --dns-additional-opts passthrough forwards extra lego DNS flags (such as --dns.resolvers or --dns.propagation-disable-ans) for environments where the authoritative name server propagation check cannot be performed. Provider credentials are supplied via --env-file: lego DNS providers read credentials only from environment variables, so the wrapper exports the file's contents before lego runs. The file is parsed like docker --env-file: literal KEY=VALUE pairs split on the first '=', comments and blank lines ignored, values taken verbatim and never executed as shell. Selecting dns-01 without --dns-provider fails fast. Co-Authored-By: Premysl Kouril <premysl.kouril@ultimum.io> Assisted-By: Claude Code Change-Id: I61dc5e3f399f6eec02475c7b90e0f41c85c6093c Signed-off-by: Timon Schnell <timon.schnell@btc-it-services.com> Signed-off-by: Jan Horstmann <horstmann@osism.tech>
github-actions
Bot
added
automated
github-actions
Bot
added
automated
priteau
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.