build: publish Linux release packages on beta - #1336
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d28bf3bae7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fi | ||
| gh release upload "${TAG}" ftw-image-digests.json \ | ||
| --repo "${GITHUB_REPOSITORY}" | ||
| bash scripts/upload-release-assets.sh "${TAG}" release/*.tar.gz release/*.sha256 |
There was a problem hiding this comment.
When this workflow is copied onto an older stable branch using the documented hotfix procedure, that branch does not contain the newly added scripts/upload-release-assets.sh, so the beta run builds successfully and then fails here with “No such file or directory.” Either inline the upload logic, fetch the helper from master, or update the hotfix procedure to bring every new dependency along with the workflow.
AGENTS.md reference: AGENTS.md:L211-L218
Useful? React with 👍 / 👎.
| done | ||
| @printf "built release/ftw-windows-amd64.zip (%s bytes)\n" \ | ||
| "$$(wc -c <release/ftw-windows-amd64.zip)" | ||
| release: release-linux |
There was a problem hiding this comment.
After release becomes Linux-only, the tracked scripts/release.sh still requires four Windows archives immediately after invoking make release; anyone using that helper now deterministically exits on the first missing Windows file and cannot upload even the successfully built Linux packages. Update or remove that helper as part of dropping the Windows targets.
AGENTS.md reference: AGENTS.md:L20-L21
Useful? React with 👍 / 👎.
1 participant
Beta releases currently provide container images but no native archives. This adds Linux arm64 and amd64 packages to beta and gives local builds, beta and stable one package builder. New releases and CI stop building Windows.
Each package contains Core, backup, web, pinned drivers, Energyplan, notices and a systemd unit. Packaging checks the architecture and resources, normalizes archive metadata and writes checksums. Upload retries check existing bytes and refuse to replace published assets. Each archive includes only its target Energyplan executable. Its filtered manifest retains source identity, schemas, licenses and original file checksums; the full pinned source bundle stays unchanged. Existing Linux download aliases remain available.
The native guide now covers a fresh Debian/Bookworm installation, version and health checks, manual updates and recovery. The systemd unit keeps config with identity and data under
/var/lib/ftwso full backups can include them together. Existing native installations using/etc/ftw/config.yamlneed a separate handover; the guide warns against replacing their unit alone.This is the first delivery step for #1308 and #1314. Docker-independent publication, copying tested beta binaries into stable, automated native installation and the public 0.x version reset remain separate work. No installed box changes here. This avoids the files owned by #1045 and #1309.
Validation:
make verify, 641 web tests and actionlint passed for the package change. The combined local test candidate with feat(api): expose charging evidence to clients and Ask why #1337 also passedmake verify.v0.131.0-beta.1candidate; checksums and embedded source commit checked. No tag or release created.